Giter Site home page Giter Site logo

Comments (29)

mootari avatar mootari commented on July 25, 2024

I also ran a search on master for tutorial links in the old format and found more potentially broken links:

862:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
889:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
911:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
934:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
964:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
993:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1022:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1127:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1205:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1243:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1266:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1332:tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
1410:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1454:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1480:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation

content/classes/2.4/MeshBuilder.md
28:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
56:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
80:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
106:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
140:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
190:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
214:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
240:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
362:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
434:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
470:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
494:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
552:tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
626:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
664:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation

content/classes/2.4/VideoTexture.md
21:Sample : https://doc.babylonjs.com/tutorials/01._Advanced_Texturing

content/classes/2.5/MeshBuilder.md
28:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
56:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
80:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
106:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
138:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
190:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
214:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
240:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
360:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
432:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
468:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
494:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
552:tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
624:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
662:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation

content/classes/2.5/Mesh.md
858:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
885:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
907:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
930:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
960:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
989:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1018:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1121:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1197:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1233:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1256:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1322:tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
1398:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1440:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
1466:Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation

content/classes/2.5/VideoTexture.md
21:Sample : https://doc.babylonjs.com/tutorials/01._Advanced_Texturing

content/overviews/PBR/Physically_Based_Rendering_Master.md
160:Shadows are fully equivalent to the Standard material. All the documentation can be found here: [Shadows](http://doc.babylonjs.com/tutorials/15._Shadows)

content/overviews/Standard/Solid_Particle_System.md
56:This is rather useful if you display only plane particles. However, if you deal only with 2D particles you should consider to use the [BJS Particle System](http://doc.babylonjs.com/tutorials/12._Particles) or the [Sprite Manager](http://doc.babylonjs.com/tutorials/08._Sprites) which are more performant in 2D computation.  
201:Remember finally that there are also some other means to deal with particles in BJS like the [Particle System](http://doc.babylonjs.com/tutorials/12._Particles) or the [Sprite Manager](http://doc.babylonjs.com/tutorials/08._Sprites) :  

scripts/helpers/builder/sources/babylon.2.5.d.ts
6910:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
6920:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
6929:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
6939:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
6952:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
6963:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
6975:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7019:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7054:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7067:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7076:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7108:         * tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
7142:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7161:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7184:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7429:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7451:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7472:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7490:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7515:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7549:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7574:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7592:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7673:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7719:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7749:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7771:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7825:         * tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
7869:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
7901:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
12188:         * Sample : https://doc.babylonjs.com/tutorials/01._Advanced_Texturing

scripts/helpers/builder/sources/babylon.2.4.d.ts
8818:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8828:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8837:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8847:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8860:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8871:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8883:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8927:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8962:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8976:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
8985:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9017:         * tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
9052:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9072:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9095:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9336:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9358:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9379:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9397:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9422:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9454:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9479:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9497:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9578:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9622:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9650:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9670:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9722:         * tuto : http://doc.babylonjs.com/tutorials/14._Height_Map
9766:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
9796:         * Detail here : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation
13218:         * Sample : https://doc.babylonjs.com/tutorials/01._Advanced_Texturing

Edit: Search was run using silver-searcher. Command: ag 'com\/tutorials\/\d+\.'

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

Hello this is really cool!
Same question: do you want to help with a PR? :)

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

We changed the structure a few time ago and I missed these refs

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

Since dead documentation links are the bane of every growing project, I wonder if this could somehow be turned into a post-deploy netlify test (I have absolutely no experience with their service)? Like, grep all domain paths, remove duplicates, check each route/path status?

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

I completely agree. Ping @Temechon and @sebavan who are more experienced in this area

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

If I'm not mistaken most of these links are taken directly from https://github.com/BabylonJS/Babylon.js and need to be fixed there.

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

correct

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

In that case I would suggest adding all affected paths as redirects to https://github.com/BabylonJS/Documentation/blob/master/public/html/_redirects until a more general solution has been devised.

It might even be wise to dig up all old tutorial paths and add redirects for them, so that external legacy links will benefit as well.

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

Ping @RaananW (not sure this is easy to do)

from olddocumentationsite.

RaananW avatar RaananW commented on July 25, 2024

Howdy!

Everything is possible. Just for me to understand, are those tutorials there with a wrong link, or are those pages "dead" and should be permanently redirected?

I'm mobile right now, but I'll look into it when I get home.

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

dead links (introduced when we reshape the folders structure)

from olddocumentationsite.

RaananW avatar RaananW commented on July 25, 2024

I can do it gladly, but if anyone else wants to do that, there is a file called _redirects in /public/html where permanent redirects can be added. Format is very simple :

/oldpath /newpath

from olddocumentationsite.

RaananW avatar RaananW commented on July 25, 2024

Each in a new line 😄

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

I started looking into deriving all necessary redirects from the git history of data/statics.json. While there are some cases that would require manual checks, all in all it should work. A major benefit would be that even intermediate changes would be covered (think e.g. old links from http://www.html5gamedevs.com/forum/16-babylonjs/).

Unfortunately I ran out of time, but I'll try to look into it some more during the next week.

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

No rush;) we appreciate the help

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

To add to the above, the contents of /_redirects could then be used to regularly scan and update links both in BabylonJS/Documentation and Babylon.js.

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

Hey did you manage to find some times for this?

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

I haven't, unfortunately, work got in the way.
I just took a look at my current code: So far I have a list of added and removed links taken from all changes to statics.json (per commit), and if I remember correctly I was looking for a good heuristic or library to diff them. Hopefully I'll find some more time to dig into it this weekend.
Btw, even if the approach may seem like overkill for this particular issue, I chose it to pick up some new strategies along the way. No link left behind. 😄

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

Lol sounds good

from olddocumentationsite.

Jaskar avatar Jaskar commented on July 25, 2024

I just finished to correct the listed moved links, and added them to the redirect file.
Thanks @RaananW for this file :)

BabylonJS/Documentation#435

from olddocumentationsite.

Jaskar avatar Jaskar commented on July 25, 2024

Also, @deltakosh video tutorials still have link with a number prefix. Is it okay ?
(http://doc.babylonjs.com/tutorials/01._3d_on_the_web_understanding_the_basics)

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

I just noticed that none of the existing redirects below /classes work, even though all of them are technically valid according to https://play.netlify.com/redirects.

I have the theory that the source (and probably the target as well) needs to be lowercase in order for the redirect to work, possibly because Netlify automatically does a redirect to lowercase before processing the request.

from olddocumentationsite.

deltakosh avatar deltakosh commented on July 25, 2024

@Jaskar it should not :) can you look at it? Thank you so much!
@mootari thanks for the hint. @RaananW do you mind having a look?

from olddocumentationsite.

Jaskar avatar Jaskar commented on July 25, 2024

@mootari Are you sure ? This one works for exemple : http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements
Even this one with an id :
http://doc.babylonjs.com/tutorials/02._Discover_Basic_Elements#side-orientation

@deltakosh Yup, I'll fix that this week-end (can't do it before).

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

@Jaskar Very, because I did extensive testing regarding case in URLs, but I can't reproduce it anymore either. Might have been fixed by now.

from olddocumentationsite.

Jaskar avatar Jaskar commented on July 25, 2024

from olddocumentationsite.

mootari avatar mootari commented on July 25, 2024

I think it was not deployed.

I was under the impression that deployment happens automatically after each successful push/merge.
Regardless, we should probably denote all redirect sources in lower case, just to avoid any potential conflicts.

from olddocumentationsite.

Jaskar avatar Jaskar commented on July 25, 2024

@deltakosh Done.
@mootari All in lowercase now, but it need a validation to merge "Master" branch to "Production" to be deployed ;)

from olddocumentationsite.

Jaskar avatar Jaskar commented on July 25, 2024

Ok, I forgot to change statics.json on my last commit.
There's my new PR : BabylonJS/Documentation#444

from olddocumentationsite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.