Comments (19)
note that this might require reindexing the how-to tutorials, please let me know when it is done.
from olddocumentationsite.
Hi @deltakosh ,
Where is it ?
from olddocumentationsite.
The search results have how_to in their title (for example - http://doc.babylonjs.com/search?q=highlight ) That's the first place I could find it in.
from olddocumentationsite.
Exactly. It is in every page from the how to (in the header)
from olddocumentationsite.
Having tried to use a space instead of _ in How_To and having got into all sorts of issues with internet URLS I ended up with doing a replace in the static.pug and statics.pug files for
h1=staticContent.category.replace("_", " ") and
h1=dataObj.category.replace("_"," ") respectively.
This seems to me to be the easiest way to do it in the search results as well and so suggest the following changes in search.js on lines 73 and 83. I will not do a push for this in case this is not the way you want to go. Not sure if there are other places the how to hyphen appears but assume a similar solution would work.
html += '<div class="basicFilter disabled" data-version="' + cat + '"><span>' + cat.replace(/_/, " ") + '</span><span>(' + numOfFiles + ')</span></div>';
html += '<a href="' + f.src + '">' + f.version.replace(/_/, " ") + ' : ' + f.name + '</a>';
from olddocumentationsite.
Ping @Temechon and @QuentinRillet
from olddocumentationsite.
Woops a few days ago I tested out my idea for replacing _ in How_To with a local build and it worked. In my last commit these changes in search.js were still in place so got committed and pushed. Honestly I am not trying to take over the documentation (or perhaps it is just my first step to world domination :) )
from olddocumentationsite.
Which commit was it?
from olddocumentationsite.
ced79cc but please note that though the change was not supposed to have been left in it does appear to solve the hyphen problem. Leave it to you as to what you want to do.
from olddocumentationsite.
This is perfect :)
from olddocumentationsite.
Should I reindex the how-tos?
from olddocumentationsite.
Nope that's the magic of it
from olddocumentationsite.
They are still shown as How_To in the search index - http://doc.babylonjs.com/search?q=highlight (even after reindexing)
from olddocumentationsite.
Ah ! Right. We need to do the little replace trick here as well:)
Ping @QuentinRillet
from olddocumentationsite.
And then I'll have to reindex ;)
from olddocumentationsite.
Sure you like it
from olddocumentationsite.
Can we reindex? ping @QuentinRillet
from olddocumentationsite.
I don't see any underscores in the search result... It seems it has already been done: BabylonJS/Documentation@ced79cc#diff-7150cea0f9818367b6d63c04bcfead00
And I don't think we need to reindex as everything is in the js. But if you really want to reindex, you can do it :)
from olddocumentationsite.
Good :)
from olddocumentationsite.
Related Issues (20)
- Match code style in Parametric Shapes tutorial to that of Playground example
- <SceneComponent /> should be <BabylonScene .../>? HOT 1
- Babylon 101 Video Tutorial Series HOT 1
- Dead links on the "Discover Basic Elements" tutorial page (Babylon101)
- Display first PG from the doc in the PG search
- Filter search for 'VR' should bring up WebXR docs HOT 4
- Arc Rotate Camera Contradiction in Docs HOT 1
- There are 89 broken links in the documentation site HOT 4
- Recreating the default configuration for the viewer has an error HOT 1
- Page not found errors on local version of Documentation HOT 2
- ArcRotationCamera.setTarget has different argument type than set target() HOT 4
- Animation blending PG in docs is broken HOT 1
- Missing info in https://doc.babylonjs.com/how_to/webxr_session_manage.
- "How to use Babylon.js with ReactJS" wrong links HOT 1
- 'jsut' Spelling mixed up issue on document doc.babylonjs.com/how_to/webxr_augmented_reality page HOT 2
- Incorrect method for customizing camera inputs HOT 2
- code in docs for Babylon React hook doesn't dispose scene on cleanup HOT 4
- SEO - Fail Doc Builds if missing Page metadata
- Clean Up Playground Namespaces HOT 1
- Turn NME doc page into an NME doc chapter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from olddocumentationsite.