Giter Site home page Giter Site logo

Comments (15)

babyman avatar babyman commented on September 15, 2024

Thanks for taking the time write a custom style, I hope support for custom CSS saves you some time (I fixed the CSS spelling error qs_wraper -> qs_wrapper too).

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

Wonderful! Thanks a bunch! So, is the update going to be available in the Chrome store soon?

P.S. I was rather fond of "wraper". ;-)

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

I've updated my style on Userstyles.org. :-)

I notice that your styles-popup.css file has a background image for
div.close, but the HTML also has the same image as an HTML element. Is
there a reason to have the image in the html if the CSS puts it there
anyway? It seems as if it would lighten your code to eliminate it from the
html.

Frances

On Sat, Sep 27, 2014 at 8:21 PM, Evan Jehu [email protected] wrote:

Thanks for taking the time write a custom style, I hope support for custom
CSS saves you some time (I fixed the CSS spelling error qs_wraper ->
qs_wrapper too).


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

babyman avatar babyman commented on September 15, 2024

@fcherman I just wanted you to know that the UI style update I just pushed out should be stable for the foreseeable future, I know it will impact you but the popup was looking quite stale. If you need any extra classes etc to make your css work please let me know.

Evan

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

​Evan, you are so sweet to let me know! I will take a look and update my
CSS. Thanks again.

Frances​

On Fri, Feb 27, 2015 at 4:37 AM, Evan Jehu [email protected] wrote:

@fcherman https://github.com/fcherman I just wanted you to know that
the UI style update I just pushed out should be stable for the foreseeable
future, I know it will impact you but the popup was looking quite stale. If
you need any extra classes etc to make your css work please let me know.

Evan


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

May I make a few suggestions for your latest "readme" file?

  • bookmarks included only a few open tabs match

This sentence is missing one or more words, and its meaning is unclear as a
result. If you would kindly explain to me what you are trying to say, I
will give you a better way to say it. I'm a marketing writer by trade, and
a native English speaker.

  • if your search starts with 1 space ' ' include bookmarks
  • if your search starts with 2 spaces ' ' only search bookmarks

You have a great opportunity here to help remind people of this feature and
how to use it, which they might otherwise forget. Replace the "Search"
placeholder text in the search field with this:

Space before: incl. bookmarks. Two spaces: only bookmarks

The number of characters just fits in the search field
​, but if you find that it doesn't, you can abbreviate bookmarks as
"bkmrks."​

Lastly, I don't know if it's just my setup, but when I turn off my custom
CSS and turn off Stylish completely to make sure I don't have any old QT
code that might be affecting it, the box on the right drops off the edge of
the popup and there's too much space on the left. Here's a screenshot.
[image: Inline image 1]

​Best wishes,

Frances​

On Fri, Feb 27, 2015 at 3:36 PM, Frances Cherman [email protected]
wrote:

​Evan, you are so sweet to let me know! I will take a look and update my
CSS. Thanks again.

Frances​

On Fri, Feb 27, 2015 at 4:37 AM, Evan Jehu [email protected]
wrote:

@fcherman https://github.com/fcherman I just wanted you to know that
the UI style update I just pushed out should be stable for the foreseeable
future, I know it will impact you but the popup was looking quite stale. If
you need any extra classes etc to make your css work please let me know.

Evan


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

babyman avatar babyman commented on September 15, 2024

<blush/> I am also a native English speaker, I have updated the readme to actually make sense (I hope), please let me know what you think :)

  • search your bookmarks:
    • bookmarks are automatically searched when only a few tabs match your search string
    • if your search string starts or ends with 1 space ' ' bookmarks are always included
    • if your search string starts or ends with 2 spaces ' ' only bookmarks are searched

I tweaked the search to make it easier to add bookmarks by including spaces at the end of the query as well and I am changing the search placeholder to "Search, start or end with spaces for bookmarks".

I'm not quite sure why the popup window would not render correctly for you and unfortunately your attachment seems to be missing, any chance you can reattach it?

Thanks so much for taking the time to read the readme (I wonder sometimes...) and your suggestions.

Evan

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

Evan, I didn't realize this conversation was appearing on your GitHub page!
I would have been more careful about making assumptions! Thanks for being a
good sport.

Regarding the bookmarks text, the first point is much clearer now. :-) For
the second and third points, I find the quotation marks and space more
confusing than helpful. I think everyone knows what a space is, so there's
no need to demonstrate, and having quotation marks with nothing visible
between them is just confusing. I also think it's clearer when instructions
are given as directives, hence, this is what I would recommend for the
second and third bullets:

  • Add a space at the end of your search string to search bookmarks along
    with tabs
  • Add two spaces at the end of your search string to search only
    bookmarks

I am again embedding the screenshot showing the shift to the right. I will
also attach it (rather than just embedding it) in case that's the problem.

Best wishes,

Frances

[image: Inline image 1]

On Fri, Feb 27, 2015 at 9:05 PM, Evan Jehu [email protected] wrote:

I am also a native English speaker, I have updated the readme to
actually make sense (I hope), please let me know what you think :)

  • search your bookmarks:
    • bookmarks are automatically searched when only a few tabs match
      your search string
    • if your search string starts or ends with 1 space ' ' bookmarks
      are always included
    • if your search string starts or ends with 2 spaces ' ' only
      bookmarks are searched

I tweaked the search to make it easier to add bookmarks by including
spaces at the end of the query as well and I am changing the search
placeholder to "Search, start or end with spaces for bookmarks".

I'm not quite sure why the popup window would not render correctly for you
and unfortunately your attachment seems to be missing, any chance you can
reattach it?

Thanks so much for taking the time to read the readme (I wonder
sometimes...) and your suggestions.

Evan


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

Okay, the CSS has been updated! Dealing with the separators was a bit
tricky since in my layout they don't actually divide anything, but I found
what I think is a reasonable solution. I suppose I could have simply hid
them with "display:none" and just distinguished the groups by color. Or I
could have made them full-width so they actually did separate the groups,
but that would sacrifice some of the "real estate" available for tabs if
the number of tabs above the separator was not an exact multiple of 3. Oh
well, there are many ways to do it.

You'll see the new CSS here:
https://userstyles.org/styles/99938/better-styling-for-chrome-extension-quick-tabs

Frances

On Fri, Feb 27, 2015 at 10:12 PM, Frances Cherman [email protected]
wrote:

Evan, I didn't realize this conversation was appearing on your GitHub
page! I would have been more careful about making assumptions! Thanks for
being a good sport.

Regarding the bookmarks text, the first point is much clearer now. :-) For
the second and third points, I find the quotation marks and space more
confusing than helpful. I think everyone knows what a space is, so there's
no need to demonstrate, and having quotation marks with nothing visible
between them is just confusing. I also think it's clearer when instructions
are given as directives, hence, this is what I would recommend for the
second and third bullets:

  • Add a space at the end of your search string to search bookmarks
    along with tabs
  • Add two spaces at the end of your search string to search only
    bookmarks

I am again embedding the screenshot showing the shift to the right. I will
also attach it (rather than just embedding it) in case that's the problem.

Best wishes,

Frances

[image: Inline image 1]

On Fri, Feb 27, 2015 at 9:05 PM, Evan Jehu [email protected]
wrote:

I am also a native English speaker, I have updated the readme to
actually make sense (I hope), please let me know what you think :)

  • search your bookmarks:
    • bookmarks are automatically searched when only a few tabs match
      your search string
    • if your search string starts or ends with 1 space ' ' bookmarks
      are always included
    • if your search string starts or ends with 2 spaces ' ' only
      bookmarks are searched

I tweaked the search to make it easier to add bookmarks by including
spaces at the end of the query as well and I am changing the search
placeholder to "Search, start or end with spaces for bookmarks".

I'm not quite sure why the popup window would not render correctly for
you and unfortunately your attachment seems to be missing, any chance you
can reattach it?

Thanks so much for taking the time to read the readme (I wonder
sometimes...) and your suggestions.

Evan


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

Okay, I just talked myself into it. I made the separators full-width. :-}

On Sat, Feb 28, 2015 at 12:56 AM, Frances Cherman [email protected]
wrote:

Okay, the CSS has been updated! Dealing with the separators was a bit
tricky since in my layout they don't actually divide anything, but I found
what I think is a reasonable solution. I suppose I could have simply hid
them with "display:none" and just distinguished the groups by color. Or I
could have made them full-width so they actually did separate the groups,
but that would sacrifice some of the "real estate" available for tabs if
the number of tabs above the separator was not an exact multiple of 3. Oh
well, there are many ways to do it.

You'll see the new CSS here:
https://userstyles.org/styles/99938/better-styling-for-chrome-extension-quick-tabs

Frances

On Fri, Feb 27, 2015 at 10:12 PM, Frances Cherman [email protected]
wrote:

Evan, I didn't realize this conversation was appearing on your GitHub
page! I would have been more careful about making assumptions! Thanks for
being a good sport.

Regarding the bookmarks text, the first point is much clearer now. :-)
For the second and third points, I find the quotation marks and space more
confusing than helpful. I think everyone knows what a space is, so there's
no need to demonstrate, and having quotation marks with nothing visible
between them is just confusing. I also think it's clearer when instructions
are given as directives, hence, this is what I would recommend for the
second and third bullets:

  • Add a space at the end of your search string to search bookmarks
    along with tabs
  • Add two spaces at the end of your search string to search only
    bookmarks

I am again embedding the screenshot showing the shift to the right. I
will also attach it (rather than just embedding it) in case that's the
problem.

Best wishes,

Frances

[image: Inline image 1]

On Fri, Feb 27, 2015 at 9:05 PM, Evan Jehu [email protected]
wrote:

I am also a native English speaker, I have updated the readme
to actually make sense (I hope), please let me know what you think :)

  • search your bookmarks:
    • bookmarks are automatically searched when only a few tabs match
      your search string
    • if your search string starts or ends with 1 space ' ' bookmarks
      are always included
    • if your search string starts or ends with 2 spaces ' ' only
      bookmarks are searched

I tweaked the search to make it easier to add bookmarks by including
spaces at the end of the query as well and I am changing the search
placeholder to "Search, start or end with spaces for bookmarks".

I'm not quite sure why the popup window would not render correctly for
you and unfortunately your attachment seems to be missing, any chance you
can reattach it?

Thanks so much for taking the time to read the readme (I wonder
sometimes...) and your suggestions.

Evan


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

babyman avatar babyman commented on September 15, 2024

Looks awesome, I hope you don't mind but I grabbed your screenshot from userstyles and added it to the readme and google store pages =).

Your bug screen cap is still not coming through, I wonder if you have to attach it directly through the github webpage?

Evan

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

I don't mind at all. I'm flattered. I'll see if I can find a way to send
you the screenshot on GitHub.

On Sat, Feb 28, 2015 at 6:18 AM, Evan Jehu [email protected] wrote:

Looks awesome, I hope you don't mind but I grabbed your screenshot from
userstyles and added it to the readme and google store pages =).

Your bug screen cap is still not coming through, I wonder if you have to
attach it directly through the github webpage?

Evan


Reply to this email directly or view it on GitHub
#66 (comment)
.

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

Evan, I tried completely removing my custom CSS (rather than commenting it out) in order to make sure that wasn't causing the shift problem, and apparently it was. With the custom CSS removed, the default styles worked fine. No need to send you a screenshot. (But I LOVE my custom styles, so I'm putting them back in).

Frances

from quick-tabs-chrome-extension.

fcherman avatar fcherman commented on September 15, 2024

Evan, FYI, if you're on a Mac and want to take a screenshot of just the popup without getting any other part of your screen, press command-shift-4, then hit the spacebar. The cursor will turn into a camera icon. Hover the camera over the window you want to shoot and hit the spacebar again. It will get a nice clean shot of the window with an attractive drop shadow, and nothing else on your screen will be visible.

from quick-tabs-chrome-extension.

babyman avatar babyman commented on September 15, 2024

Awesome, I'm relieved that the defaults are rendering properly for you =)

Thanks for the screenshot tip, I always use cmd+option+shift+4 and forget about the rest! I think I will redo the screen caps and add some text to describe the extensions functionality more, things like the shortcuts keys.

Evan

from quick-tabs-chrome-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.