Giter Site home page Giter Site logo

Comments (5)

argiepiano avatar argiepiano commented on September 2, 2024

PR #142 ready for review.

from feeds.

argiepiano avatar argiepiano commented on September 2, 2024

Again a test failure - no time to check, but this may be unrelated.

from feeds.

MegaChriz avatar MegaChriz commented on September 2, 2024

This "required" mark was added to avoid modules accidentally getting disabled while they were still in use by importers. I'm not familiar with Backdrop yet, but the idea is that you are not allowed to disable the module in question (via the UI or on the command line [for example: using drush, not sure if drush is compatible with backdrop]) until all importers that depend on it are removed. If the "disabled" mark still preserves this behavior, then that's great!

See here the issue in which the "required" mark was added: https://www.drupal.org/node/2379407

At first glance, the test failures look unrelated. I saw some messages about classes that could not be found. Based on your changes, I would find it highly unlikely that that would result in tests not be able to find classes.

from feeds.

argiepiano avatar argiepiano commented on September 2, 2024

Thanks, @MegaChriz!! Yes, in BAckdrop, the key disabled disables the checkbox and prevents disabling the module. It's used by the field core module to avoid disabling it when there are fields. See this line

from feeds.

herbdool avatar herbdool commented on September 2, 2024

Merged

from feeds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.