Comments (8)
Just to update, after the latest commit this timeout bug still exists. But I can now visit admin/structure/taxonomy/tags and view a "Translate" tab, which seems to function at a basic level (as opposed to the 2nd error above).
from i18n.
Same as #2 -- a matching error shows up in watchdog if I've got i18n_menu
disabled and i18n_taxonomy
enabled, and I try to go to the vocabulary's "Configure" page:
Notice: Undefined property: stdClass::$language in i18n_langcode() (line 277 of /Users/user/buildkit/build/backdrop-demo/modules/i18n/i18n.module).
https://github.com/backdrop-contrib/i18n/blob/1.x/i18n.module#L277
from i18n.
A new PR is available. Please test. It fixes (should fix) all those errors plus brings basic functionality.
Really, please test.
from i18n.
@indigoxela The main functionality seems to be working well -- amazing! Here are some observations and a few issues I found along the way. Take them for what they are worth at this stage.
- Taxonomy > Manage Display shows a blank field (when that vocabulary is set to "Translate."):
- Taxonomy > Manage Fields gives an error (when that vocabulary is set to "Translate."):
Error: Unsupported operand types
- An "Undefined" translation set is created at some point:
- Not sure if it's related to this module, but on vocabs that do not have multilingual options enabled, the table columns/headers are not matched correctly:
from i18n.
@laryn many thanks for testing! Yes, I also observed some odd behavior when switching between types (translate, localize, none...). And I also observed that handling translation sets should get more robust.
I'll have a look at that table header problem, too. (Weekend is coming 😉)
from i18n.
@laryn More commits have been made to my PR, which address point 1 and 2 (many thanks for pulling this out).
And it should be much harder now to create a broken "Undefined" translation set (point 3). It might still be possible, though.
As you already suspected, point 4 is unrelated to i18n. Thats backdrop/backdrop-issues#3869
In case you still see php notices, try to start with a fresh database. The broken translation sets might have created incomplete taxonomy terms that could interfere.
...and report all the remaining issues here. 😉
from i18n.
Thanks again @indigoxela ! More comments from a walkthrough on a fresh install:
-
There is no default or requirement on the "Extended" radio buttons after enabling Multilingual on a vocab. Is that supposed to be that way?
-
I tested "Localize" first and that seemed to be working well. Then I changed configuration to "Translate" and the term I had localized had no translation (I suppose the localized data doesn't transfer automatically) so I added a translation to the term. This seems to work pretty well (1 and 2 in my earlier comment are fixed) however, I see this twice in the log:
Notice: Undefined index: langcode in i18n_taxonomy_form_alter() (line 918 of /app/modules/i18n/i18n_taxonomy/i18n_taxonomy.module).
Also, the "Translation sets" page continues to create/show an "undefined" set:
- I was going to test "Fixed language" but I'm not sure what that is supposed to do. It forces me to choose a language in the configuration for that option:
But when I am creating a new term, it still lists all language options:
from i18n.
@laryn Thanks again for testing.
Re point 1 - probably this should have a default value...
Re point 2 - nice catch! I didn't realize that php notice, should be fixed now. And to clarify: localize and translate are fundamentally different (different submodules actually).
Re "Undefined" translation sets: can you provide the steps to create one, please?
Re point 3 - fixed language. I took a look at that now, it should be working with the latest commits (the language dropdown in Backdrop is provided by core).
Happy testing again. 😉
from i18n.
Related Issues (20)
- Capitalize all 'translate' titles for consistency HOT 3
- Default language selection HOT 7
- GHA: Switch to actions/checkoutv3
- i18n_menu_block_view_alter overrides custom block titles HOT 12
- [term:i18n-vocabulary:name] token doesn't seem to be working HOT 13
- i18n_select: option "Select taxonomy terms by language" is missing HOT 6
- Warning: Undefined array key "i18n_node"
- Submodule i18n_taxonomy uses deprecated function
- Autocomplete term filtering revisited
- Cleanup: remove dead code
- Coding standards revisited
- Tokens in field descriptions not replaced HOT 3
- Update test runs
- Compatibility with PHP 8.2 HOT 1
- Need a hook_config_info() in i18n_select so config file is owned by that module HOT 3
- Call to undefined method i18n_object_wrapper::strings_remove() HOT 3
- Problem making changes to Text format configuration with i18n HOT 8
- Update GHA (checkout-v4)
- i18n_taxonomy: The function _menu_load_objects()... called deprecated function taxonomy_vocabulary_machine_name_load HOT 1
- Some change in core 1.28.0 broke i18n_taxonomy in combination with views HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from i18n.