Giter Site home page Giter Site logo

Comments (6)

indigoxela avatar indigoxela commented on July 28, 2024 1

@laryn many thanks for your PR, I'll look into this ASAP, but maybe not before weekend.

from i18n.

laryn avatar laryn commented on July 28, 2024 1

Hmm... it's actually not working completely. I hadn't actually tried saving the translation, which produces an SQL syntax error with this PR.

from i18n.

laryn avatar laryn commented on July 28, 2024 1

Manually patched my dev site and did some testing -- basic functionality is looking good! A few visual/UI suggestions that come to mind as I am testing:

  • can the submit button be wrapped in a '#type' => 'actions' array? I think this gives the button more consistent styling with the rest of the UI
  • Adding the CKEditor interface also adds "Formatting options" so the manually added description is duplication:
    Screenshot_2021-04-19 Translate to Español
  • The CKEditor editing window opens very narrow, it should maybe be made taller by default:
    Screenshot_2021-04-19 Translate to Español_2

from i18n.

indigoxela avatar indigoxela commented on July 28, 2024

@laryn should be fixed in 16c2a2e. Please test thoroughly, the automated tests are passing, but "human eyes" still might find something. 😃

from i18n.

indigoxela avatar indigoxela commented on July 28, 2024

...A few visual/UI suggestions that come to mind...

@laryn many thanks for testing. The visual glitches should be fixed in 11ff8c9.

from i18n.

laryn avatar laryn commented on July 28, 2024

Looks great!

from i18n.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.