Giter Site home page Giter Site logo

Comments (13)

1egoman avatar 1egoman commented on July 17, 2024 1

Turns out it was just a hardcoded value from my mockups that I forgot to change. https://github.com/backstrokeapp/dashboard/blob/master/src/components/link-list/index.js#L93

No security issues here!

Fixed in backstrokeapp/dashboard@a9811dd. Thanks again @brysgo!

from server.

brysgo avatar brysgo commented on July 17, 2024

My best guess is that the deployment is using your whoamiMock.

from server.

1egoman avatar 1egoman commented on July 17, 2024

😲

I'll take a look and see if I can debug the issue. Thanks for bringing it to my attention.

from server.

brysgo avatar brysgo commented on July 17, 2024

for some reason app.backstroke.co still logs me in as you

from server.

1egoman avatar 1egoman commented on July 17, 2024

@brysgo Can you give me a screenshot? Where does it indicate that you are logged in as me?

from server.

brysgo avatar brysgo commented on July 17, 2024

screen shot 2017-09-17 at 8 27 55 pm

from server.

1egoman avatar 1egoman commented on July 17, 2024

That isn't good. Did you get an oauth prompt to login with github? What are the steps that you took to get into that state?

I just tried to login with another Github account that I have and I couldn't replicate this behavior. What I did:

  1. Visited https://backstroke.co.
  2. Clicked on login
  3. Accepted the oauth prompt for the other github account.
  4. Was redirected back to app.backstroke.co, with an empty screen as expected.

from server.

1egoman avatar 1egoman commented on July 17, 2024

Just tried again and was able to replicate. I'll do some digging and see what's up. Thanks for letting me know about this, this is a serious issue.

from server.

1egoman avatar 1egoman commented on July 17, 2024

@brysgo I think I figured it out. Just pushed up a fix, can you confirm that you don't see this behavior anymore?

from server.

brysgo avatar brysgo commented on July 17, 2024

@1egoman - got further, before having the same problem

from server.

1egoman avatar 1egoman commented on July 17, 2024

@brysgo Can you elaborate? Are you still able to impersonate my user account?

from server.

brysgo avatar brysgo commented on July 17, 2024

@1egoman - It seems to be working now :-)

from server.

1egoman avatar 1egoman commented on July 17, 2024

Cool, glad I was able to solve this!

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.