Giter Site home page Giter Site logo

Comments (3)

arkivanov avatar arkivanov commented on May 28, 2024 1

@aartikov as per my comment above, this function is to ensure there is only one type of component in the stack, and to bring it to front. I suggest to use sealed classes instead of enums, or just use navigate(...) directly.

from decompose.

arkivanov avatar arkivanov commented on May 28, 2024

The name navigateSingleTop is misleading in this context, as it has different semantics in Android. We should find a better name. This function should work in the following way:

  • If there is already a component in the stack with configuration of type T, then that component should be moved to top of the stack.
  • Otherwise a new component should be created and pushed to the stack.

Some possible names: reorderToFront, makeOnTop, activate, activateOrPush, bringToFrontOrPush

from decompose.

aartikov avatar aartikov commented on May 28, 2024

@arkivanov
stack.filterNot { it::class == configuration::class } + configuration

Maybe it would be better to compare values rather than classes?
Otherwise, we can't use enums for bottom navigation items.

from decompose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.