Giter Site home page Giter Site logo

Comments (5)

GhOsTMZ avatar GhOsTMZ commented on July 4, 2024

Some improvements for decreasing a compilation time. MySQL can be built without a server binary. For example:

cmake -DWITH_BOOST=boost_1_59_0 -DWITHOUT_SERVER=1 && make

This checked on percona server.

And I don't understand why you installed nanomsg. You using static linking and nanomsg installing it is not necessary.

I can upload my ugly rpmspec-file if you want. This can be a good starting point for a building pinba engine.

from pinba2.

anton-povarov avatar anton-povarov commented on July 4, 2024

Nice tip, thanks.
rpmspec is also welcome of course.

from pinba2.

GhOsTMZ avatar GhOsTMZ commented on July 4, 2024

https://github.com/badoo/pinba2/files/3886244/pinba-engine.txt

rpmspec checked on centos 7 and percona server 5.7. devtoolset-7 required but not listed in BuildRequires. mysql-devel needed only for mysql_config utility for determine mysql plugin directory.

from pinba2.

anton-povarov avatar anton-povarov commented on July 4, 2024

Thanks for the spec! At a brief glance, i think macro.patch file is referenced but missing from the upload?

from pinba2.

GhOsTMZ avatar GhOsTMZ commented on July 4, 2024

I can give a macro.patch. But it's a ugly hack for building from sources got by not a git clone command. If you getting sources by git clone you can exclude this patch.

diff -ru pinba2-2.5.0/mysql_engine/plugin.cpp pinba2-2.5.0.new/mysql_engine/plugin.cpp
--- pinba2-2.5.0/mysql_engine/plugin.cpp        2019-04-24 17:34:00.000000000 +0300
+++ pinba2-2.5.0.new/mysql_engine/plugin.cpp    2019-11-21 12:21:52.439922930 +0300
@@ -154,8 +154,8 @@
 
        // version and build info
        snprintf(vars->version_info, sizeof(vars->version_info),
-               "%s %s, git: %s, branch: %s, modified: %s",
-               PINBA_PACKAGE_NAME, PINBA_VERSION, PINBA_VCS_FULL_HASH, PINBA_VCS_BRANCH, PINBA_VCS_WC_MODIFIED);
+               "%s %s",
+               PINBA_PACKAGE_NAME, PINBA_VERSION);
 
        snprintf(vars->build_string, sizeof(vars->build_string), "%s", PINBA_BUILD_STRING);
 
@@ -262,7 +262,7 @@
                return std::make_shared<mysql_logger_t>(stderr, log_level);
        }();
 
-       LOG_NOTICE(logger, "version {0}, git: {1}, build: {2}", PINBA_VERSION, PINBA_VCS_FULL_HASH, PINBA_BUILD_STRING);
+       LOG_NOTICE(logger, "version {0}, build: {1}", PINBA_VERSION, PINBA_BUILD_STRING);
 
        try
        {

from pinba2.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.