Improper file extension detection

[bakape]

Improper file extension detection

[medukatheguca]

thumbnailer/archives.go

Line 113 in 0b14c80

for _, ext := range [...]string{".png", ".jpg", ".jpeg", ".webp"} {

ext to lowercase will fix the issue

[bakape]

Since when are upper case extensions allowed?

[medukatheguca]

You can upload an archive with uppercase extensions inside which I guess don't get checked by the thumbnailer the same way they normally do as single files.

[bakape]

There is no reason it should be rejected based on the extension, but I should also not accommodate user retardation.

…

On Tue, 12 Mar 2019 at 21:38, medukatheguca ***@***.***> wrote: You can upload an archive with uppercase extensions which I guess doesn't get checked yet by the thumbnailer. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#52 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHfPsB_olDtba5HIflLwAAk7xyiAJfGcks5vWAIogaJpZM4brCdL> .

[medukatheguca]

Here's a reference of an archive of pngs and an archive of PNGs

[bakape]

PEBCAK

[Chiiruno]

Yes, however it's a simple enough fix to accommodate said problem without a real performance penalty.