Giter Site home page Giter Site logo

Comments (6)

leafduo avatar leafduo commented on May 28, 2024

What do you mean by "clean previous script context"? I suppose you mean reverting the effect of previous script.

In my opinion, it's not easy (if not impossible) to clean up the effect of all method swizzling, newly defined classes and their instances. For example, it's not possible to remove a protocol conformance at runtime AFAIK.

from jspatch.

xilin avatar xilin commented on May 28, 2024

@leafduo Yes, that's what I mean. So if I cannot clean up the effects, can I redefine all the method swizzling?

I tried but it seems in JSPatch only the first loaded script works when I defined two implementation for the same method.

from jspatch.

bang590 avatar bang590 commented on May 28, 2024

Remove the if () here to allow redefine methods: JPEngine.m#L695.

from jspatch.

xilin avatar xilin commented on May 28, 2024

@bang590 It works now! So what's the purpose to forbid redefine methods? I think this is common way when applying hotfix.
Or can we make this configurable?

from jspatch.

bang590 avatar bang590 commented on May 28, 2024

@xilin I can't remember why, maybe it just for some history problem, It's removed just now: 5c0459f

from jspatch.

xilin avatar xilin commented on May 28, 2024

@bang590 Thanks for the modification.

from jspatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.