Giter Site home page Giter Site logo

Comments (17)

TomasShaggy avatar TomasShaggy commented on June 12, 2024

Hey, did u figure it out please? if yes, pls let me know

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

baptistebriel avatar baptistebriel commented on June 12, 2024

Sorry for the delay in answering here.
I've uploaded a new demo which uses GSAP ScrollTrigger: c5dffd6

It should work on both native: true and native: false versions. Basically ScrollTrigger needs to know which property is the scrollTop value within the module (scroll.vars.target or scroll.vars.current) and a method to tell ScrollTrigger to update.

To run the demo examples, simply clone/download the repository and start http-server within the root folder on your terminal. Let me know if that helps and if you're having any issues!

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

baptistebriel avatar baptistebriel commented on June 12, 2024

Hey @ashehzadgec,

Thanks for providing an update on the demo. Good catch. Your solution fixed it, thanks!
I am not sure what the issue is when you "pin elements making the position fixed"?

I've added some code to the demo. Please not that this is a bit of a hack, but again the markers are here just for development purposes. Make sure you remove this code once you go live. I'm basically just moving GSAP's markers inside of the section since there is no scrolling on the element with native: false, so they wouldn't update position once you start scrolling.

Again, sorry about the delay in answering. Happy to hear this helped and you're enjoying the module!

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

baptistebriel avatar baptistebriel commented on June 12, 2024

Hey, seems like we can just completely drop the callback function like the demo they sent. Not sure what is still wrong with this demo? What are you trying to achieve by pinning elements?

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

sbtly avatar sbtly commented on June 12, 2024

I also want to use GSAP ScrollTrigger with pin: true option with this library.

from smooth-scrolling.

baptistebriel avatar baptistebriel commented on June 12, 2024

Hey guys, I haven't had the chance to look it up as I'm currently busy with client work. I'll have a look when I get the chance.

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

ashehzadgec avatar ashehzadgec commented on June 12, 2024

from smooth-scrolling.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.