Giter Site home page Giter Site logo

Comments (8)

barbushin avatar barbushin commented on May 30, 2024

Great idea! I just tested it, and I see that it's very easy to override standard console.* functions. I'll implement it soon, when I have some free time.

from javascript-errors-notifier.

jrnail23 avatar jrnail23 commented on May 30, 2024

@barbushin, thanks for the quick reply -- that feature would be really great for me and my team, as we test our React apps.
React writes warnings & errors to the console when you violate certain design/coding rules, and this would be a great way to make those problems more visible for us. 😄

from javascript-errors-notifier.

barbushin avatar barbushin commented on May 30, 2024

I deployed v2.1.26 in Google WebStore. It's going to be reviewed by WebStore team and published in about 1 hour. Then it will take few hours before your Chrome will download new version. You can use chrome://extensions/ to force updating to new version.

Please let me know if it works fine. Thanks!

from javascript-errors-notifier.

jrnail23 avatar jrnail23 commented on May 30, 2024

@barbushin, dude, you freaking rock. 💯

from javascript-errors-notifier.

dsherret avatar dsherret commented on May 30, 2024

This caused a lot of issues! stack[3] does not always match the regex in this code. For example, there is no parenthesis in this stack[3]:

"    at https://some-website-goes-here.net/Scripts/FloatingPanel.js:10:10"

When this fails, it throws an error that halts the execution of any code that uses console.warn or console.error. Websites like Jira are barely usable with this extension enabled.

I would highly suggest being a bit more defensive (ex. assume callSrc could be null) and not halt execution of code that uses console.warn/console.error when there is an error in this extension. I bet a lot of people using this extension are confused about why websites aren't working today.

from javascript-errors-notifier.

barbushin avatar barbushin commented on May 30, 2024

@dsherret But it's already fixed in fe2be66 Isn't it?

from javascript-errors-notifier.

barbushin avatar barbushin commented on May 30, 2024

@dsherret David, you was right. There was some another case with undefined index error. I fixed it in last commit and deployed in WebStore. Looks good for you?

from javascript-errors-notifier.

dsherret avatar dsherret commented on May 30, 2024

@barbushin yup, everything's working fine now. Thanks!

from javascript-errors-notifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.