Empty errors popup dialog if "Block third-party cookies and site data" enabled

[barbushin]

Empty errors popup dialog if "Block third-party cookies and site data" enabled

[himdel]

When clicking the bottom icon, an empty popup appears and an error pops up in the console:

popup.js:12 Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at initOptionSwitcher (chrome-extension://iihnpeckfoopfonmeeeclmcfecbaafjn/popup.js:12:50)
    at HTMLDocument.<anonymous> (chrome-extension://iihnpeckfoopfonmeeeclmcfecbaafjn/popup.js:28:2)

Clicking the address bar icon works just fine, the popup contains the right info.

---

(assuming that's the right issue:)

Would it make sense to solve this by adding an option to disable the popup icon completely?

Or does it make more sense to fix this by fixing #43 (assuming chrome.storage is not limited by that "Block 3rd party" option), and make enabling/disabling the icon an unrelated feature?

EDIT: although, it turns out the "Show error notification icon on all domains" option is the magic bullet needed to switch the icon off completely. (Sorry, that "on all domains" made me think the option was about ignoring the localhost/non-localhost distinction, not about hiding the icon.)

(Never mind, I'm solving this by disabling the icon, and what I really want is to get a proper notification popup on errors, so I'll try to open a PR adding chrome.notifications support.)

[barbushin]

It's a very special case, so I don't think that it will be possible to fix it without cutting JEN functionality.