Giter Site home page Giter Site logo

Comments (5)

sschaub avatar sschaub commented on June 12, 2024 1

Does it work properly in XamarinMediaManager with your binding changes?

With this change, I was able to create a build of XamarinMediaManager that works for XF 5. I believe this change is just restoring bindings that were in effect for earlier versions of ExoPlayerXamarin, so I doubt it will introduce a regression for downstream projects.

from exoplayerxamarin.

ArchangelWTF avatar ArchangelWTF commented on June 12, 2024

This is an interesting one (I saw you already made a PR) I pretty much came across this too when cleaning up ExoPlayer.Common in an attempt to fix it up for XamarinMediaManager, but I wasn't sure if changing the DataSources would lead to further regressions so I left it be.

Does it work properly in XamarinMediaManager with your binding changes?

from exoplayerxamarin.

martijn00 avatar martijn00 commented on June 12, 2024

@sschaub I merged it but the other extensions don't compile with this change. Can you fix that so i can make a release?

from exoplayerxamarin.

sschaub avatar sschaub commented on June 12, 2024

My apologies, @martijn00, for breaking the build. I made a newbie assumption that turned out to be wrong. I think I've corrected it.

from exoplayerxamarin.

martijn00 avatar martijn00 commented on June 12, 2024

I've fixed the last errors now and pushed some other changes. New version is online at nuget. I'll push this to MediaManager too, not sure if it works after that...

from exoplayerxamarin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.