Add formatting checks in RiakObject on ContentType set: a valid content type has a slash in it.

[basho]

Add formatting checks in RiakObject on ContentType set: a valid content type has a slash in it.

[OJ]

I'd forgotten about this issue.

I'm not sure I agree. Why can't the user have their own custom content type? I'm pretty sure that nobody would, but surely this should be up to the dev?

[peschkaj]

I will dig into the source, but I'm pretty sure this is expected to be a valid MIME type.

---

Jeremiah Peschka
Founder, Brent Ozar Unlimited

On Nov 30, 2012, at 2:12 AM, OJ Reeves [email protected] wrote:

I'd forgotten about this issue.

I'm not sure I agree. Why can't the user have their own custom content type? I'm pretty sure that nobody would, but surely this should be up to the dev?

—
Reply to this email directly or view it on GitHub.

[peschkaj]

webmachine/mochikit is checking for valid HTTP content-type headers at some point in the Riak code base.

Since we can't viably lock out HTTP clients, it does serve our purposes to make sure a valid HTTP content type is set. Checking for supported MIME types is probably excessive for 1.0, but we can at least check for the presence of "/" to weed out clear failures of content types. See http://en.wikipedia.org/wiki/Internet_media_type for lulz.

[OJ]

That check would make sense for cases where things are being pushed in through HTTP, but does the PB interface do the same thing? If it's in webmachine/mochikit I can't see how that's enforced via PB.

Damn, now you've made me want to investigate :)

[peschkaj]

Well, you can't put invalid data in. If nothing else we should punt on this
and let the users decide.

---

Jeremiah Peschka
Founder, Brent Ozar Unlimited

On Fri, Nov 30, 2012 at 2:34 PM, OJ Reeves [email protected] wrote:

That check would make sense for cases where things are being pushed in
through HTTP, but does the PB interface do the same thing? If it's in
webmachine/mochikit I can't see how that's enforced via PB.

Damn, now you've made me want to investigate :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-10906770.

[peschkaj]

Confirmed with @seancribbs that this has to be a valid MIME type, but it does not have to be a registered MIME type. As such, it has to be of the format \w+(\w+)? Or, to the non-insane, TYPE with an optional SUB_TYPE. As far as we're concerned, it can't be null or an empty string. This is checked when calling SetObject.