Giter Site home page Giter Site logo

Failed JS MR includes Erlang terms about riak_kv HOT 4 CLOSED

basho avatar basho commented on September 28, 2024
Failed JS MR includes Erlang terms

from riak_kv.

Comments (4)

russelldb avatar russelldb commented on September 28, 2024

I'm pretty sure this is deliberate as of Bryan's work to have more meaningful errors come out of MapReduce.

from riak_kv.

rzezeski avatar rzezeski commented on September 28, 2024

So I'm hearing that this change was intentional. I.e. returning the input field as a string of an Erlang term. That seems to make sense to me. I just have 2 concerns:

  1. I'm not sure it makes sense to return the error field as a string of Erlang terms. Client writers have to parse a very awkward string to get at the various fields such as lineno, message and source.
  2. This beaks any clients that are using JS and relied on the lineno, message, and source fields being top-leve in the object.

I just want to make sure we are aware of these two points.

@seancribbs Given you are the guy in charge of the client team I think it's best if you make the call here. What do you say?

from riak_kv.

seancribbs avatar seancribbs commented on September 28, 2024

@rzezeski I don't know any part of the clients that explicitly expects specific fields in a MapReduce error response. I think the error message should be plain text as much as possible, but the offending input could go either way.

from riak_kv.

rzezeski avatar rzezeski commented on September 28, 2024

I'm closing this since it is intended behavior.

from riak_kv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.