Make Crud Command index.blade.php directory & mkdir in error

[bastinald]

Make Crud Command index.blade.php directory & mkdir in error

[bastinald]

Thank you for your work! While this was designed with Mac & Linux, I want to ensure it works for people on Windows too.

I'll be implementing the fixes you mentioned shortly.

[bastinald]

Can you confirm everything else is working fine aside from the CRUD command?

It's kind of a pain in the ass to set up Laragon on Parallels...

[bastinald]

Should work on Windows now as of version 2.1.5

[Thiktak]

Not fixed :(

S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3>php artisan make:crud Test/TestA                                                                                                                                          
Bastinald\LaravelLivewireUi\Commands\MakeCrudCommand::setReplaces                                                                                                                                                                   
Bastinald\LaravelLivewireUi\Commands\MakeCrudCommand::makeStubs                                                                                                                                                                     
makeStubs: S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\app/Http/Livewire//Test/TestAs/Index.php\Index.php                                                                                                             
File created: app/Http/Livewire//Test/TestAs/Index.php\Index.php                                                                                                                                                                    
makeStubs: S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\app/Http/Livewire//Test/TestAs/Index.php\Read.php                                                                                                              
File created: app/Http/Livewire//Test/TestAs/Index.php\Read.php                                                                                                                                                                     
makeStubs: S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\app/Http/Livewire//Test/TestAs/Index.php\Save.php                                                                                                              
File created: app/Http/Livewire//Test/TestAs/Index.php\Save.php                                                                                                                                                                     
makeStubs: S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\resources\views/test\test-as\index.blade.php  

The makestubs is still try to create a file as a folder. Results:
./Test/TestAs/index.php/index.blade.php

The responsible is:

        $this->componentDir = Str::replaceLast(
            DIRECTORY_SEPARATOR . 'index.php',
            '',
            $this->componentParser->relativeClassPath()
        );

Indeed, it return a file, because it's not removing the Index.php due to namespace separator and not directory separator. Need to sanitize to handle the two / & .
DIRECTORY_SEPARATOR = ""
$this->componentParser->relativeClassPath() = "app/Http/Livewire//Test/TestAs/Index.php"

At the end:

        $this->componentDir = $this->componentParser->relativeClassPath();
        $this->componentDir = Str::replaceLast('\Index.php', '', $this->componentDir);
        $this->componentDir = Str::replaceLast('/Index.php', '', $this->componentDir);

and, bacause I still have the joining of paths:

            $basePath = base_path(str_replace(base_path(), '', $path));

And by the way, now I have another error:
file_put_contents(S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\app/Database/Factories//TestAFactory.php): Failed to open stream: No such file or director

The error is comming from MakeAModelCommand $this->factoryParser. An extra / is added at the baseClassPath (I don't understand why !)

  +"baseClassNamespace": "Database\Factories"                                                                                                                                                                                       
  +"baseTestNamespace": "Tests\Feature\Livewire"                                                                                                                                                                                    
  +"baseClassPath": "S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\app/Database/Factories//"                                                                                                                            
  +"baseViewPath": "S:\Devs\xampp\htdocs\www\projects\p4_lv8_my_work\my_work3\resources\views/"                                                                                                                                     
  +"baseTestPath": "S:/Devs/xampp/htdocs/www/projects/p4_lv8_my_work/my_work3/tests/Feature/Livewire/" 

My current fix:

    private function replaceFactoryPath($method)
    {
        return str_replace(
            '//',
            '/',
            Str::replaceFirst(
                'app/Database/Factories',
                'database' . DIRECTORY_SEPARATOR . 'factories',
                $this->factoryParser->$method()
            )
        );
    }

[bastinald]

Are you using all of the latest versions of all packages?

Can you run composer update and try again? I thought I had all this stuff fixed.

If it still persists after running composer update I'll see what I can do.

I might have to bite the bullet and actually install Windows lol.

[Thiktak]

Hi,

Yes. Used composer update. And even the fresh install.
I saw lot of DIRECTORY_SEPARATOR in you last commits. But I guess, sometimes you have namespace separator ( \ ) logic, and there is a mix between them.

(here it's more linked to the migration package)

(still // and still the app directory path on the replaceFactoryPath function)

I fixed, and tried to create a CRUD.

Again:

[bastinald]

Can you composer update to version 2.1.3 of the migration package and try creating a model via the make:amodel command? I made some more changes and hope it works.

If you could add me on discord bastinald#3568 so we can do this together so I don't have to install Windows that would help...

[bastinald]

Closing this as its now fixed.