Giter Site home page Giter Site logo

Comments (17)

dericed avatar dericed commented on June 16, 2024 1

Can you try the recent daily build

from qctools.

dericed avatar dericed commented on June 16, 2024 1

Steps to reproduce:

  1. make sample: ffmpeg -f lavfi -i testsrc2 -f lavfi -i sine -t 10 test.mkv
  2. open in qctools, select a frame and press 'm' and add a comment
  3. export legacy xml.gz
  4. close test.mkv and reopen, it should load and comment is visible
  5. select another frame and add comment
  6. rename current legacy xml.gz report
  7. export new xml.gz report
  8. close test.mkv and reopen, it should crash

In this scenario you now have two xml.gz, when I diff I see in xml #1, the stream_index values are set properly (0 and 1) in xml #2, the stream_index values are set to -1 so impossible to associate frames with their streams.

Also in xml #2, now all video frames include <tag key="qctools.comment" value="N/A"/> if there's no comment (xml #1 only includes comment node if there's a comment).

Also in the xml#1, there is one comment (expected). In xml #2 (when ignoring all the N/A comments) there are two frames with comments, but the first one is repeated.

            <tag key="lavfi.signalstats.UBITDEPTH" value="8.000000"/>
            <tag key="lavfi.signalstats.YBITDEPTH" value="8.000000"/>
            <tag key="qctools.comment" value="comment on first open then save xmlgz"/>
            <tag key="qctools.comment" value="comment on first open then save xmlgz"/>
        </frame>

from qctools.

BleakleyMcD avatar BleakleyMcD commented on June 16, 2024

@dericed anyone else having this problem?

from qctools.

BleakleyMcD avatar BleakleyMcD commented on June 16, 2024

We are on QCTools Version 1.2.1 running 12.6.6 on an M1 MacBook Pro.

from qctools.

EmCNabs avatar EmCNabs commented on June 16, 2024

@dericed @BleakleyMcD A step forward!

I updated to the daily build and was able to make a comment and export a QC Tools Report. (Huzzah!)

But then when I tried to open that QCTools Report to check for the comment, QCTools crashed and now I am no longer able to export a QC Tools Report. :(

from qctools.

ElderOrb avatar ElderOrb commented on June 16, 2024

Just exported .qctools.mkv with 2 comments successfully.

@EmCNabs what OS you are using? Qt5 or Qt6 build of QCTools? Can you please share video causing issues (or try another one to make sure the issue is not video-specific)?

from qctools.

dericed avatar dericed commented on June 16, 2024

or sharing the qctools report might be sufficient

from qctools.

EmCNabs avatar EmCNabs commented on June 16, 2024

I have tried with several different mkv videos & reports. They have all had the same issues: either not saving with comments, or saving & then QC Tools crashing when trying to open the .qctools.mkv report with comments.

Laptop info:
Mac OS: Monterey 12.6.5
QC Tools: Version 1.2.1.20230629

Here is a link to a folder with 3 of the qctools.mkv reports I have been using as tests for saving comments.
https://drive.google.com/drive/folders/1nE5XtgvH2EQVHCmQc8p8rxTCL1pZvCbk?usp=drive_link

The one called "Mouse_QCTReport...mkv.qctools.mkv" is the report that is causing QCTools to crash.

from qctools.

ElderOrb avatar ElderOrb commented on June 16, 2024

@EmCNabs interesting, report has invalid 'stream_index' (-1) and this is the reason for crash on opening. As I can see crash is unrelated to comments. Can you please share video itself ?

from qctools.

dericed avatar dericed commented on June 16, 2024

@EmCNabs or could you paste the output of ffprobe "/Users/medialab/Desktop/vrecord Capture/Test Tapes/MadAboutTheMouse/Test2_MAtM.mkv" -show_format -show_streams. Was this qctools report generated by QCTools or vrecord? Noting that in the <frame> elements, the stream_index for both the video and audio frames is set to -1 so it's a challenge to correlate the frames to the streams. I'm curious why this happened.

from qctools.

EmCNabs avatar EmCNabs commented on June 16, 2024

@dericed The "Test2_MAtM.mkv" transfer & original QCTools report were made using vrecord. On 6/28 the comments were added & exported via QCTools.

I ran ffprobe off the copy of the file I have on my laptop. The video transfers are done via Blackmagic UltraStudio 4k mini & vrecord to Mac mini in the office.

ffprobe Output:
≈:≈ ffprobe /Users/nabasnye/Desktop/QC/MadAboutTheMouse/Test2_MAtM.mkv -show_format -show_streams
ffprobe version 6.0 Copyright (c) 2007-2023 the FFmpeg developers
built with Apple clang version 14.0.0 (clang-1400.0.29.202)
configuration: --prefix=/opt/homebrew/Cellar/ffmpeg/6.0 --enable-shared --enable-pthreads --enable-version3 --cc=clang --host-cflags= --host-ldflags= --enable-ffplay --enable-gnutls --enable-gpl --enable-libaom --enable-libaribb24 --enable-libbluray --enable-libdav1d --enable-libmp3lame --enable-libopus --enable-librav1e --enable-librist --enable-librubberband --enable-libsnappy --enable-libsrt --enable-libsvtav1 --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libxvid --enable-lzma --enable-libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libspeex --enable-libsoxr --enable-libzmq --enable-libzimg --disable-libjack --disable-indev=jack --enable-videotoolbox --enable-neon
libavutil 58. 2.100 / 58. 2.100
libavcodec 60. 3.100 / 60. 3.100
libavformat 60. 3.100 / 60. 3.100
libavdevice 60. 1.100 / 60. 1.100
libavfilter 9. 3.100 / 9. 3.100
libswscale 7. 1.100 / 7. 1.100
libswresample 4. 10.100 / 4. 10.100
libpostproc 57. 1.100 / 57. 1.100
[matroska,webm @ 0x150f04a50] Could not find codec parameters for stream 2 (Attachment: none): unknown codec
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0x150f04a50] Could not find codec parameters for stream 3 (Attachment: none): unknown codec
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
Input #0, matroska,webm, from '/Users/nabasnye/Desktop/QC/MadAboutTheMouse/Test2_MAtM.mkv':
Metadata:
creation_time : 2022-11-15T20:43:20.857870Z
ENCODER : Lavf59.27.100
Duration: 00:36:00.02, start: 0.000000, bitrate: 81847 kb/s
Stream #0:0: Video: ffv1 (FFV1 / 0x31564646), yuv422p10le(tv, smpte170m/smpte170m/bt709, bottom coded first (swapped)), 720x486, SAR 9:10 DAR 4:3, 29.97 fps, 29.97 tbr, 1k tbn
Metadata:
ENCODER : FFV1 version 3
DURATION : 00:36:00.024000000
Stream #0:1: Audio: flac, 48000 Hz, stereo, s32 (24 bit)
Metadata:
ENCODER : Lavc59.37.100 flac
DURATION : 00:35:59.700000000
Stream #0:2: Attachment: none
Metadata:
filename : Test2_MAtM_capture_options.log
mimetype : text/x-log
title : Capture options selected by user during vrecord process
Stream #0:3: Attachment: none
Metadata:
filename : Test2_MAtM_vrecord_input.log
mimetype : text/x-log
title : Full FFmpeg output from vrecord capture process
Unsupported codec with id 0 for input stream 2
Unsupported codec with id 0 for input stream 3
[STREAM]
index=0
codec_name=ffv1
codec_long_name=FFmpeg video codec #1
profile=unknown
codec_type=video
codec_tag_string=FFV1
codec_tag=0x31564646
width=720
height=486
coded_width=720
coded_height=486
closed_captions=0
film_grain=0
has_b_frames=0
sample_aspect_ratio=9:10
display_aspect_ratio=4:3
pix_fmt=yuv422p10le
level=-99
color_range=tv
color_space=smpte170m
color_transfer=bt709
color_primaries=smpte170m
chroma_location=unspecified
field_order=bt
refs=1
id=N/A
r_frame_rate=30000/1001
avg_frame_rate=30000/1001
time_base=1/1000
start_pts=0
start_time=0.000000
duration_ts=N/A
duration=N/A
bit_rate=N/A
max_bit_rate=N/A
bits_per_raw_sample=10
nb_frames=N/A
nb_read_frames=N/A
nb_read_packets=N/A
extradata_size=202
DISPOSITION:default=0
DISPOSITION:dub=0
DISPOSITION:original=0
DISPOSITION:comment=0
DISPOSITION:lyrics=0
DISPOSITION:karaoke=0
DISPOSITION:forced=0
DISPOSITION:hearing_impaired=0
DISPOSITION:visual_impaired=0
DISPOSITION:clean_effects=0
DISPOSITION:attached_pic=0
DISPOSITION:timed_thumbnails=0
DISPOSITION:captions=0
DISPOSITION:descriptions=0
DISPOSITION:metadata=0
DISPOSITION:dependent=0
DISPOSITION:still_image=0
TAG:ENCODER=FFV1 version 3
TAG:DURATION=00:36:00.024000000
[/STREAM]
[STREAM]
index=1
codec_name=flac
codec_long_name=FLAC (Free Lossless Audio Codec)
profile=unknown
codec_type=audio
codec_tag_string=[0][0][0][0]
codec_tag=0x0000
sample_fmt=s32
sample_rate=48000
channels=2
channel_layout=stereo
bits_per_sample=0
initial_padding=0
id=N/A
r_frame_rate=0/0
avg_frame_rate=0/0
time_base=1/1000
start_pts=0
start_time=0.000000
duration_ts=N/A
duration=N/A
bit_rate=N/A
max_bit_rate=N/A
bits_per_raw_sample=24
nb_frames=N/A
nb_read_frames=N/A
nb_read_packets=N/A
extradata_size=34
DISPOSITION:default=0
DISPOSITION:dub=0
DISPOSITION:original=0
DISPOSITION:comment=0
DISPOSITION:lyrics=0
DISPOSITION:karaoke=0
DISPOSITION:forced=0
DISPOSITION:hearing_impaired=0
DISPOSITION:visual_impaired=0
DISPOSITION:clean_effects=0
DISPOSITION:attached_pic=0
DISPOSITION:timed_thumbnails=0
DISPOSITION:captions=0
DISPOSITION:descriptions=0
DISPOSITION:metadata=0
DISPOSITION:dependent=0
DISPOSITION:still_image=0
TAG:ENCODER=Lavc59.37.100 flac
TAG:DURATION=00:35:59.700000000
[/STREAM]
[STREAM]
index=2
codec_name=unknown
codec_long_name=unknown
profile=unknown
codec_type=attachment
codec_tag_string=[0][0][0][0]
codec_tag=0x0000
id=N/A
r_frame_rate=0/0
avg_frame_rate=0/0
time_base=1/90000
start_pts=0
start_time=0.000000
duration_ts=194402160
duration=2160.024000
bit_rate=N/A
max_bit_rate=N/A
bits_per_raw_sample=N/A
nb_frames=N/A
nb_read_frames=N/A
nb_read_packets=N/A
extradata_size=39024
DISPOSITION:default=0
DISPOSITION:dub=0
DISPOSITION:original=0
DISPOSITION:comment=0
DISPOSITION:lyrics=0
DISPOSITION:karaoke=0
DISPOSITION:forced=0
DISPOSITION:hearing_impaired=0
DISPOSITION:visual_impaired=0
DISPOSITION:clean_effects=0
DISPOSITION:attached_pic=0
DISPOSITION:timed_thumbnails=0
DISPOSITION:captions=0
DISPOSITION:descriptions=0
DISPOSITION:metadata=0
DISPOSITION:dependent=0
DISPOSITION:still_image=0
TAG:filename=Test2_MAtM_capture_options.log
TAG:mimetype=text/x-log
TAG:title=Capture options selected by user during vrecord process
[/STREAM]
[STREAM]
index=3
codec_name=unknown
codec_long_name=unknown
profile=unknown
codec_type=attachment
codec_tag_string=[0][0][0][0]
codec_tag=0x0000
id=N/A
r_frame_rate=0/0
avg_frame_rate=0/0
time_base=1/90000
start_pts=0
start_time=0.000000
duration_ts=194402160
duration=2160.024000
bit_rate=N/A
max_bit_rate=N/A
bits_per_raw_sample=N/A
nb_frames=N/A
nb_read_frames=N/A
nb_read_packets=N/A
extradata_size=3883
DISPOSITION:default=0
DISPOSITION:dub=0
DISPOSITION:original=0
DISPOSITION:comment=0
DISPOSITION:lyrics=0
DISPOSITION:karaoke=0
DISPOSITION:forced=0
DISPOSITION:hearing_impaired=0
DISPOSITION:visual_impaired=0
DISPOSITION:clean_effects=0
DISPOSITION:attached_pic=0
DISPOSITION:timed_thumbnails=0
DISPOSITION:captions=0
DISPOSITION:descriptions=0
DISPOSITION:metadata=0
DISPOSITION:dependent=0
DISPOSITION:still_image=0
TAG:filename=Test2_MAtM_vrecord_input.log
TAG:mimetype=text/x-log
TAG:title=Full FFmpeg output from vrecord capture process
[/STREAM]
[FORMAT]
filename=/Users/nabasnye/Desktop/QC/MadAboutTheMouse/Test2_MAtM.mkv
nb_streams=4
nb_programs=0
format_name=matroska,webm
format_long_name=Matroska / WebM
start_time=0.000000
duration=2160.024000
size=22098985163
bit_rate=81847183
probe_score=100
TAG:creation_time=2022-11-15T20:43:20.857870Z
TAG:ENCODER=Lavf59.27.100
[/FORMAT]

from qctools.

EmCNabs avatar EmCNabs commented on June 16, 2024

QCTools also crashes when I try to open the file "Test_File01.mkv.qctools.xml". I have also added this to the Google Drive folder

Which if I read the QCTools manual correct, should open a report in QCTools.

from qctools.

BleakleyMcD avatar BleakleyMcD commented on June 16, 2024

@dericed @ElderOrb @EmCNabs Just wondering if this could be looked into?

from qctools.

BleakleyMcD avatar BleakleyMcD commented on June 16, 2024

@dericed I'm not sure I follow... is this a bug or is it user error?

from qctools.

dericed avatar dericed commented on June 16, 2024

It's a bug. The steps I listed reproduce the issue with simple steps for debugging. I was primarily adding notes for @ElderOrb who's working on this one.

from qctools.

BleakleyMcD avatar BleakleyMcD commented on June 16, 2024

😎😎😎😎 thanks! @EmCNabs

from qctools.

dericed avatar dericed commented on June 16, 2024

fixed in #793

from qctools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.