abseil-cpp is missing dependency on googletest?

[bazelbuild]

abseil-cpp is missing dependency on googletest?

[grencez]

Version 20230802.0 of the abseil-cpp module introduced a googletest dependency. (Unlike google_benchmark, which was changed to a dev_dependency in the .bcr.1 patch.)

Is this issue resolved? In an acceptable way?

[alexeagle]

Maybe you're depending on the wrong targets in abseil? You probably shouldn't have any dependency on the :hash_testing target. Are you trying to bazel query @abseil-cpp//... or something? You could also use a bazel query somepath(//my:targets, @abseil-cpp.20210324.2//absl/hash:hash_testing) to see whether this dependency is legit.

[tkoeppe]

I was using the @//... (or //...) pattern to build everything. You're right that I don't have any dependency on :hash_testing from my own repository.

[alexeagle]

Then I think this is WAI - it's often the case that an external repository has targets which aren't expected to build in userland (e.g. many rulesets have a docs/ folder with a stardoc dependency, but users aren't expected to install stardoc).

[tkoeppe]

Mind you, I am not building @com_google_absl//... (I renamed the import); but @//... -- i.e. my own repo. I don't think importing an external repo should leak into the @-space, should it?

[tkoeppe]

Ah no, never mind! I do depend on :hash_testing directly. Sorry!

https://github.com/deepmind/lab2d/blob/89f3dd2c498410b5201d271ca50860f311025ca6/dmlab2d/lib/system/grid_world/collections/BUILD#L15

Is :hash_testing not part of the public API of Abseil? I was using absl::VerifyTypeImplementsAbslHashCorrectly to test my hash implementation.

[Wyverald]

Ah. This could be a "feature"-like feature that we're still missing. :hash_testing does look like a public API, but probably not every dependent of Abseil wants to use it, and hence they might not want a dependency on googletest at all.

Right now, Abseil either has a dependency on googletest, or doesn't; it cannot "sometimes" depend on googletest. In Cargo for example this is solved by "features" -- when adding a dependency, you can add on optional features (in this case, the "testing utils" feature of Abseil) that themselves bring in new dependencies. But this problem can be alternatively solved by splitting the feature into a separate module, so we haven't prioritized this.

So for the time being, we could either just add googletest as a dependency to Abseil, or try to split out the "testing utils" parts of Abseil into a separate module.