Comments (3)
I'm working on this right now. Actually slight correction, there needs to be an input like
[a for b in c
]
[ #comment on the first line of a container with the opening [ or ( or { will be eaten
]
for the bug to materialize
from buildtools.
Currently buildifier doesn't allow to make comment on a multiline list, for example:
items = [
a,
b,
] # a list of items
also it doesn't allow commenting on a function call:
foo(
x,
y,
) # bar
I'm working on this issue and I'd like to remove these restrictions as they seem to be related to the initial problem. Are there any objections / reasons why buildifier is implemented this way?
from buildtools.
Another example of a missing comment:
[
x
for x in y #foo
if x # bar
]
is formatted to
[
x
for x in y
if x
]
due to a bug in the printer.
from buildtools.
Related Issues (20)
- ERROR: --noenable_bzlmod :: Unrecognized option: --noenable_bzlmod HOT 1
- buildifier moves licenses() and distribs() from mainline to the package() declaration
- buildifier rule with check mode is deprecated but buildifier_test is not documented
- buildifier_test does not complain when passix fix as a mode
- new_load to= aliases broken HOT 1
- Virus Total Flagging latest Buildozer Darwin Amd64 as infected HOT 2
- [buildifier]: add lint warning for disallowed load
- [buildozer]: Support adding symbols instead of literal strings HOT 1
- Unable to go install tagged version since introduction of `v` prefix HOT 1
- Buildtools release artifacts are unsigned and have no checksum files
- buildozer doesn't accept "BUILD.bazel" HOT 1
- buildifier destroys `load()` statements targeting the same name HOT 2
- Buildozer: Handle multiple glob arguments in 'set' arguments HOT 1
- Release request HOT 5
- Feature Request - Provide a 'diff' mode for buildozer
- Buildifier doesn't recognise `MODULE.bazel`
- new_load local naming syntax with `=` no longer works
- constant-glob fails to lint when the first argument is named
- no such target '@@com_github_bazelbuild_buildtools//buildifier:runner.bat.template'
- Add s390x arch support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildtools.