Plugin doesn't work against recent Bazel version

[bazelbuild]

Plugin doesn't work against recent Bazel version

[damienmg]

I am using it at head. I will do a new release on Monday.

…

On Sat, Dec 9, 2017, 6:29 PM Hans ***@***.***> wrote: (*thump*) (*thump*) Is this thing on? 😅 Using bazel 0.8.0 fails with: ERROR: /private/var/tmp/_bazel_censored/d524661b555353cf611f531fca4c7d0f/external/com_google_appengine_remote_api/BUILD:13:1: in //tools/must/be/unique:e4b_aspect.bzl%e4b_aspect aspect on java_import rule @com_google_appengine_remote_api//:link: Traceback (most recent call last): File "/private/var/tmp/_bazel_censored/d524661b555353cf611f531fca4c7d0f/external/com_google_appengine_remote_api/BUILD", line 13 //tools/must/be/unique:e4b_aspect.bzl%e4b_aspect(...) File "/Applications/Eclipse.app/Contents/Eclipse/plugins/com.google.devtools.bazel.e4b_0.0.2/resources/tools/must/be/unique/e4b_aspect.bzl", line 88, in _aspect_impl set() The `set` constructor for depsets is deprecated and will be removed. Please use the `depset` constructor instead. You can temporarily enable the deprecated `set` constructor by passing the flag --incompatible_disallow_set_constructor=false This appears to be fixed 9 months ago in #51 <#51> / 94c6f4a <94c6f4a> What's stopping a new release? Has anyone successfully built the plugin locally and can give hints? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf9rAB7jr0OOfxDNmTbG97GVG4qw-ks5s-sOKgaJpZM4PZx3n> .

[davido]

Looks like uncommenting these lines: ~/pgm/eclipse-oxygen/eclipse/plugins/com.google.devtools.bazel.e4b_0.0.2/resources/tools/must/be/unique/e4b_aspect.bzl fixed the first breakage:

  for attr_name in DEPENDENCY_ATTRIBUTES:
    if hasattr(rule_attrs, attr_name):
      deps = getattr(rule_attrs, attr_name)
      if type(deps) == 'list':
#        for dep in deps:
#          ide_info_text = ide_info_text | dep.intellij_info_files.ide_info_text
#          ide_resolve_files = ide_resolve_files | dep.intellij_info_files.ide_resolve_files
        all_deps += [str(dep.label) for dep in deps]

[davido]

Well, now it's failing in android rules. I don't use android:

ERROR: /home/davido/.cache/bazel/_bazel_davido/0fa756dec521553dbe2dde6b6eac99b4/external/bazel_tools/tools/android/BUILD:267:1: Executing genrule @bazel_tools//tools/android:no_android_sdk_repository_error failed (Exit 1).
This build requires an Android SDK. Please add the android_sdk_repository rule to your WORKSPACE.
____Elapsed time: 222.555s, Critical Path: 30.76s

[damienmg]

Arf this is fixed at head. I need to cut a new release for the plugin.

[markuskobler]

Anything stopping a new release?

[hridder]

(thump) (thump) Is this thing on? 😅

Using bazel 0.8.0 fails with:

ERROR: /private/var/tmp/_bazel_censored/d524661b555353cf611f531fca4c7d0f/external/com_google_appengine_remote_api/BUILD:13:1: in //tools/must/be/unique:e4b_aspect.bzl%e4b_aspect aspect on java_import rule @com_google_appengine_remote_api//:link: 
Traceback (most recent call last):
	File "/private/var/tmp/_bazel_censored/d524661b555353cf611f531fca4c7d0f/external/com_google_appengine_remote_api/BUILD", line 13
		//tools/must/be/unique:e4b_aspect.bzl%e4b_aspect(...)
	File "/Applications/Eclipse.app/Contents/Eclipse/plugins/com.google.devtools.bazel.e4b_0.0.2/resources/tools/must/be/unique/e4b_aspect.bzl", line 88, in _aspect_impl
		set()
The `set` constructor for depsets is deprecated and will be removed. Please use the `depset` constructor instead. You can temporarily enable the deprecated `set` constructor by passing the flag --incompatible_disallow_set_constructor=false

This appears to be fixed 9 months ago in #51 / 94c6f4a

What's stopping a new release? Has anyone successfully built the plugin locally and can give hints?

[damienmg]

Closing this bug in favor of #57.