docker_push not working

[bazelbuild]

docker_push not working

[chaitanya9186]

Forgot to mention:
I able to use docker_build rule to build and tag the docker image and able to push the same using docker push <image> command.

[mattmoor]

Thanks for filing the issue!

I will try to reproduce this myself, but it smells like an incompatibility with Gitlab (I'll have to find a way to set up an account to test pushing).

[mattmoor]

Also, for completeness, have you tried docker_pull with Gitlab and it is working?

[chaitanya9186]

I have tried docker_pull, it looks like working to me.

[mattmoor]

Ah, I know what the problem is.

This is using a variant of the specification that is more efficient (for the sizes of layers typically produced by Bazel), but that docker/distribution does not implement, but that I implemented in GCR.

Basically, for blob uploads there are three modes:

1. POST w/ layer payload as body -- Unsupported by docker/distribution
2. POST/PUT w/ layer payload as body of PUT -- pre-1.8
3. POST/PATCH/PUT w/ layer payload as body of PATCH -- 1.8+

Cross-repo mounting is sort of like a 1b., but it falls back on 3. when it fails.

The client we use has dormant functionality to implement the other modes (that I implemented for benchmarking which was best), but it'll take a little doing to update the unit testing with the new requests to expect.

My apologies, I had forgotten we used this under the hood. I'll try to get a fix in and a new release cut in the next few days.

[chaitanya9186]

Awesome. Thanks for the update and the details.

[mattmoor]

This comment spells it out the best, and you are the unfortunate victim of my TODO :)
https://github.com/google/containerregistry/blob/master/client/v2_2/docker_session_.py#L183

[mattmoor]

tl;dr I have a couple changes out for (internal) review to the underlying tooling that performs the push, which I believe will resolve this.

With these changes I have already successfully pushed an image to DockerHub and Gitlab, but...

After setting up an account on registry.gitlab.com my initial attempt at using it to push there has resulted in a failure similar to one I initially encountered with JFrog's bintray, which was a result of them using a feature of HTTPS called SNI.

The problem is that the version of python 2.7 bundled with the latest Ubuntu LTS is a couple minor versions short of where this is added. You can see my more detailed comment here.

The good news (for you) is that if docker_pull was successful and docker_push got as far as the failure you experienced, then you are already past this and shouldn't have this problem.

I'll add a limited pull test for Gitlab (similar to the above bintray) to the Travis configuration shortly.

[mattmoor]

@chaitanya9186 Can you try using the commit in the linked PR and confirm that this resolves your problem?

[chaitanya9186]

@mattmoor I have just tried it. It is working.

Thanks for the quick fix.

[mattmoor]

Awesome, I'll merge the PR then. LMK if you have any other issues.