nogo: Allow not running analyzers for certain packages

[DolceTriade]

nogo: Allow not running analyzers for certain packages

[fmeum]

Have you seen https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/bzlmod.md#configuring-nogo? It looks like this would cover your use case, it just uses Bazel instead of Go packages to identify the inclusion/exclusion scope.

[DolceTriade]

Is this exclusively using bzlmod? Unfortunately it will take some time for us migrate to bzlmod.

[fmeum]

Is this exclusively using bzlmod? Unfortunately it will take some time for us migrate to bzlmod.

For now yes, but if we can find a way to realize the same configuration option for WORKSPACE, we could definitely open it up. The general setup is there.

[DolceTriade]

I'll look into that approach.

[DolceTriade]

Do you think the approach should be to expose includes/excludes into go_register_toolchains or just to expose go_register_nogo to workspace users?

It sounds like the latter is the right thing to do. Maybe make a wrapper that automatically sets the name...

As a workaround:

This works until we can migrate to bzlmod.

load("@io_bazel_rules_go//go/private:nogo.bzl", "go_register_nogo")

# Add lint checking
go_register_nogo(
    name = "io_bazel_rules_nogo",
    includes = ["@@//:__subpackages__"],
    nogo = "@//bazel/go:lint",
)

[fmeum]

Yes, the approach of providing a simple macro wrapper around your workaround sounds best to me.

Could you add a test along the lines of the existing Bzlmod test? This would help us clarify how the WORKSPACE way of configuring nogo interacts with apparent vs. canonical repository names.

[DolceTriade]

Took another stab at this here: #3842