reindexChildrenOfNode doesn't seem to work right > 9 items...

[bbc]

reindexChildrenOfNode doesn't seem to work right > 9 items...

[jfrux]

Wow, actually... just discovered it was the dist/index.min.js that wasn't sorting properly...
Somehow with the dist/index.js its working.

[jfrux]

I take this back... this is still very much a bug.
It MAY be an issue with certain browsers or something...

My app is deployed in FireTV and I put some console logs inside of Lrud.getNodeLastChild() and it looks like this... I did a fresh build after adding console.logs to the index.ts's getNodeLastChild(); like so...

getNodeLastChild(node: Node): Node {
    console.log("getNodeLastChild()");
    if (!node.children) {
      return undefined
    }
    console.log("node.children before sorting",JSON.parse(JSON.stringify(node.children)));
    const orderedIndexes = Object.keys(node.children).map((childId) => {
      const childIndex = node.children[childId].index;
      console.log(`Mapping child ${childId} to ${childIndex}`);
      return childIndex;
    }).sort();
    console.log("orderedIndexes after sorting",JSON.parse(JSON.stringify(orderedIndexes)));
    console.log("lastIndex of orderedIndex:",orderedIndexes.length - 1);
    return _findChildWithIndex(node, orderedIndexes[orderedIndexes.length - 1])
  }

So what's happening is... since the last index returns 9... the wrapping nature of the response is always 9.

[jfrux]

const orderedIndexes = Object.keys(node.children).map(childId => node.children[childId].index).sort()

to

const orderedIndexes = Object.keys(node.children).map(childId => node.children[childId].index)

Fixes the problem.

Having that seemingly innocent extra sort() without the callback to tell it how to sort it...

[epatrasc]

Hi @jfrux ,

Thanks for your investigation, you're right. The sort, without a proper callback, is not sorting the indexes correctly, it's treating number as string.

I'll open a PR to fix the issue.