Giter Site home page Giter Site logo

Comments (7)

nicholasgriffintn avatar nicholasgriffintn commented on June 22, 2024 1

Well no, the use case of needing the Message type is not that great (we haven't been exporting it for about half a year).

I'm not sure that it's that big of an ask for the user to import it directly themselves honestly, it's not something we're ever going to modify.

This isn't a bug either btw, so I'm gonna change the labelling.

from sqs-consumer.

nicholasgriffintn avatar nicholasgriffintn commented on June 22, 2024

I'm not sure this is actually required, as you need to install sqs-client anyway, it's realistically not that different or better from doing this:

import { Message } from '@aws-sdk/client-sqs';

I'll have a think on it, we did used to do it, but that was when we were adjusting the type ourselves.

from sqs-consumer.

matehuszarik avatar matehuszarik commented on June 22, 2024

I'm a bit confused because the @aws-sdk/client-sqs pkg is added to peerDependencies and dependencies too.
https://github.com/bbc/sqs-consumer/blob/main/package.json#L65

Because of this, I'm not required to install the pkg separately.

from sqs-consumer.

nicholasgriffintn avatar nicholasgriffintn commented on June 22, 2024

As of version 7 of npm, peer dependencies are also auto installed, but either way, you still need to install it yeah.

from sqs-consumer.

matehuszarik avatar matehuszarik commented on June 22, 2024

As of version 7 of npm, peer dependencies are also auto installed

Exactly, so I don't have to add @aws-sdk/client-sqs to dependencies separately and can not import the Message type. This is the problem I'd like to solve.

IMO sqs-consumer should either enforce the installation of @aws-sdk/client-sqs or re-export the Message type.

from sqs-consumer.

nicholasgriffintn avatar nicholasgriffintn commented on June 22, 2024

This has sort of been done in #385 I'm not happy with it though due to the docs issues.

Thinking about the time I have available, I'm going to decide not to do this, if anyone would still like to do this, feel free to open a new pr with the documentation fixed.

from sqs-consumer.

github-actions avatar github-actions commented on June 22, 2024

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

from sqs-consumer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.