Giter Site home page Giter Site logo

Comments (2)

nicholasgriffintn avatar nicholasgriffintn commented on July 20, 2024

Hey, yeah we can't react to the code Error or the error type SQSError overall as this would make every error from SQS a connection error that's not what we're looking to do.

One possible way of detecting might be to look for ENOTFOUND, but that's also a little hacky and not super supported.

I don't think we can't ultimately support every possible use case with this library, and we're not really looking to, it's main aim is to be simple boilerplate that we used internally and shared externally.

from sqs-consumer.

fraserbenjamin avatar fraserbenjamin commented on July 20, 2024

Hey, yeah we can't react to the code Error or the error type SQSError overall as this would make every error from SQS a connection error that's not what we're looking to do.

One possible way of detecting might be to look for ENOTFOUND, but that's also a little hacky and not super supported.

I don't think we can't ultimately support every possible use case with this library, and we're not really looking to, it's main aim is to be simple boilerplate that we used internally and shared externally.

Yeah 100% agree and appreciate your time on this so far thanks, with high traffic that could cause a big delay if the odd message fails for a genuine reason. Totally understand not being able to support every use case although surely a malformed url or no connection are 2 very common cases especially if deploying to cloud where a malformed security group or bad env variable could then cause high cpu/memory and lots of potentially expensive logging to occur without people realising straight away. Especially since the loop can be every 1-2ms which is a lot of events.

In the first draft PR I raised I added another configurable option that a timeout happens on any errors which whilst not perfect I'd say is a better alternative than having the potential for the issues mentioned above. Would be keen to know your opinion on adding something like that back in, happy to do the work but want to check its the way you'd like to go first.

from sqs-consumer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.