Comments (13)
This really depends on wether #388 is considered a bug or not.
from codeigniter.
... or not - ignore my last comment.
from codeigniter.
+1 for scrapping the "conversion programatic characters" - it is pointless, has the potential to waste a lot of time 'debugging' and it is incorrect. the code essentially performs a limited "html entitizing" ... html entitizing is something you do to output not input!
from codeigniter.
Hasn't this been address by #388? Can this be closed?
from codeigniter.
#388 has nothing to do with this ... other issues related to this one have been fixed, but the suggestion here is to remove this filter altogether.
from codeigniter.
I think enough people are having issues with it and that it does not have a clear advantage, so in my opinion it should be removed.
from codeigniter.
I agree that the substitution should be removed. RFC 3986 says that the dollar sign and parentheses are safe characters and do not need encoding. They are also flagged as "reserved" characters, which can be encoded and interpreted by an application, but that appears to be subsequent to any use as a URI.
from codeigniter.
I'm voting for removing it.
from codeigniter.
+1 for "conversion programatic characters" removal. The three presented justifications are good enough.
Edit: Justification 4: Such characters within a segment may be needed as a result of sloppy slug generation. If you use url_title() for this purpose, the segment would be clean, and then the "programatic characters" simply may not be enabled using the setting $config['permitted_uri_chars'].
url_title() may be reworked to transliterate from non-Latin languages, but this is another story.
from codeigniter.
I vote for it too.
from codeigniter.
Well, the public opinion seems to be unanimous.
@pfote @benedmunds @druu @lonnieezell Any objections?
from codeigniter.
No objection.
from codeigniter.
I can't think of a reason it's really needed, but haven't scoured the code about this either.
No objection.
from codeigniter.
Related Issues (20)
- CodeIgniter Forums - Cannot Register HOT 1
- GitHub actions is failing HOT 1
- migration
- PHP 8.2 - Optional parameter declared before required parameter HOT 1
- Is Codeigniter version 3.1.10 is support for php 8.0 or php 8.1 ? HOT 13
- Deprecated Deprecations of Expected Exceptions HOT 1
- CodeIgniter + Session usage with Redis is slow HOT 4
- mysqli_driver version_compare issue CI 3.1.13
- Controller classes must exist as files (why??)
- Drop support for PHP < 8.1 HOT 10
- Crazy error, php-api/system/database/DB_driver.php --------> function escape($str) error HOT 4
- Email library does not send email through SMTP on PHP 8.2
- Upcoming deprecations in PHP 8.3 HOT 2
- Codeigniter 3.1.4 and PHP 8.1 HOT 4
- mysqli num_rows always return 0 HOT 1
- Session Lost for CI 3.1.13 on Page Refresh HOT 4
- Misleading docblock of the file_get_info function
- xss_clean % error HOT 1
- Bug: inconsistent behavior of Query Builder limit 0 HOT 8
- bug: codeigniter3 db->or_where_not_in(...) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codeigniter.