Giter Site home page Giter Site logo

Comments (4)

kewix avatar kewix commented on April 27, 2024

I have the same issue using postgre driver... please fix this one this a major bug !

from codeigniter.

bkirkman avatar bkirkman commented on April 27, 2024

Tim, thanks for addressing this issue. I think it might need some tweaking, or I am not implementing correctly. Using the above query as an example.

    $this->db->join('tasks', 'projects.id = tasks.project_id AND tasks.deleted=0', 'left')

will create a query string like

    LEFT JOIN `tasks` ON `projects`.`id` = `tasks`.`project_id` AND `tasks`.`deleted`=`0`

Protecting 0 causes a MySQL error. I'm not even sure if this type of case should be automatically handled in the join method. I would of course like it to be, but it might break some other case. For now, I'm just protecting identifiers long hand in the active record query itself, kind of like this post.

http://codeigniter.com/forums/viewthread/119846/#737096

from codeigniter.

Dentxinho avatar Dentxinho commented on April 27, 2024

This issue is related to #758 and if properly fixed may replace the solution given on #759.
Line 331 should match breaklines and tabs too.

from codeigniter.

philsturgeon avatar philsturgeon commented on April 27, 2024

This is being handled in #759.

from codeigniter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.