Module Manager: execTransactionFromModule does not emit module events

[zakrad]

Module Manager: execTransactionFromModule does not emit module events

[Aboudjem]

Hey @zakrad 😊
thank you for pointing this out. The design choice was made for specific reasons, but your observation about consistency is valid. We'll review the implementation and consider making adjustments in future iterations. Thanks again your feedback is valuable to us! 👍

Can you please check and address this @filmakarov ? thanks

[livingrockrises]

we could potentially add below code here

if (success) {
            emit ModuleTransaction(msg.sender, to, value, data, operation);
            emit ExecutionFromModuleSuccess(msg.sender);
        } else {
            emit ExecutionFromModuleFailure(msg.sender);
        }

can check this diff view. will get it internally reviewed with the team
https://github.com/bcnmy/scw-contracts/pull/154/files

[Aboudjem]

Thank you @zakrad for your valuable contribution. We have addressed the issues you brought to our attention and made the necessary fixes. Your input has been extremely helpful in improving our project.

[zakrad]

It's also not possible to specify txGas for execTransactionFromModuleReturnData is it possible to update that also?