Bit of a type mismatch between HD.fromSeed and HDPrivateKey.fromSeed

[haxwell]

Bit of a type mismatch between HD.fromSeed and HDPrivateKey.fromSeed

[haxwell]

Another case is here in hd.js

 * Instantiate an hd private key from a mnemonic.
 * @param {Mnemonic|Object} mnemonic
 * @returns {HDPrivateKey}
 */

HD.fromMnemonic = function fromMnemonic(options) {
  return HDPrivateKey.fromMnemonic(options);
};

The method that it eventually calls is in lib/hd/private.js:

  /**
   * Inject properties from a mnemonic.
   * @private
   * @param {Mnemonic} mnemonic
   * @param {String?} passphrase
   */

  fromMnemonic(mnemonic, passphrase) {
    assert(mnemonic instanceof Mnemonic);
    return this.fromSeed(mnemonic.toSeed(passphrase));
  }

It requires a Mnemonic, but the method above it allows for non-Mnemonic objects.

[manavdesai27]

I have created a PR, adopting the necessary changes.