Comments (8)
we can make it logger
that would look better right?
from beanstalkg.
logger
conflicts with many existing packages. e.g., https://godoc.org/github.com/coreos/rkt/tests/testutils/logger
Switching log
to logger
in architecture/{job,protocol,tube}.go
imports the above package in job.go
on save.
from beanstalkg.
we can explicitly create a logger in every file we need.
Do you see any problem with that? Otherwise naming this way seems kind of weird.
from beanstalkg.
Where is this pre save hook added? I can not find it in the repo?
from beanstalkg.
I also noticed just now when I was trying to test some of your changes locally that the logging seems to misbehave when I run it. For example debug logs show up even though I have not enabled it.
from beanstalkg.
Explicitly creating a logger works.
from beanstalkg.
The pre-save hook is in my emacs config.
Try calling goimports on save.
from beanstalkg.
closing this as the solution is explicitly creating a logger.
from beanstalkg.
Related Issues (20)
- Implement stats command
- Implement list-tubes command HOT 7
- implement list-tube-used command
- implement list-tubes-watched command
- Implement quit command HOT 2
- implement pause-tube command
- Create integration test framework
- Try ginkgo HOT 1
- bury command results with BAD_FORMAT error HOT 1
- consider introducing a cmd package for main
- Introduce validation for command parameters in protocol config HOT 4
- Add interfaces to allow jobs and job history to be persisted.
- Check if existing beanstalkd clients have a problem with job ids being string HOT 2
- reserve-with-timeout seem to be buggy HOT 2
- debug log at every tick on master branch HOT 1
- Cannot resolve getConfig HOT 2
- Delete command does not delete the job sometimes when there are many workers connected to the same tube
- Disconnected clients create problem with job serving for other clients
- dead? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beanstalkg.