Giter Site home page Giter Site logo

Comments (8)

vimukthi-git avatar vimukthi-git commented on May 24, 2024

we can make it logger that would look better right?

from beanstalkg.

stephenwithav avatar stephenwithav commented on May 24, 2024

logger conflicts with many existing packages. e.g., https://godoc.org/github.com/coreos/rkt/tests/testutils/logger

Switching log to logger in architecture/{job,protocol,tube}.go imports the above package in job.go on save.

from beanstalkg.

vimukthi-git avatar vimukthi-git commented on May 24, 2024

we can explicitly create a logger in every file we need.

Do you see any problem with that? Otherwise naming this way seems kind of weird.

from beanstalkg.

vimukthi-git avatar vimukthi-git commented on May 24, 2024

Where is this pre save hook added? I can not find it in the repo?

from beanstalkg.

vimukthi-git avatar vimukthi-git commented on May 24, 2024

I also noticed just now when I was trying to test some of your changes locally that the logging seems to misbehave when I run it. For example debug logs show up even though I have not enabled it.

from beanstalkg.

stephenwithav avatar stephenwithav commented on May 24, 2024

Explicitly creating a logger works.

from beanstalkg.

stephenwithav avatar stephenwithav commented on May 24, 2024

The pre-save hook is in my emacs config.

Try calling goimports on save.

from beanstalkg.

vimukthi-git avatar vimukthi-git commented on May 24, 2024

closing this as the solution is explicitly creating a logger.

from beanstalkg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.