Validation isNumber() can accept empty space

[bearstudio]

Validation isNumber() can accept empty space

[ivan-dalmet]

That was my first idea but in reality, all rules should accept "empty" (null, undefined, "") value.
Because this rule is handled with the isRequired rule (or required property).

Example for optional field:

Now 😕:

<Field
  name="myField"
  validations={[
    {
      rule: val => !value && value !== 0 ? true : isNumber()(value)
      message: 'not a number',
    },
    {
      rule: val => !value && value !== 0 ? true : isMinNumber(1)(value)
      message: 'not under 1',
    },
    {
      rule: val => !value && value !== 0 ? true : isMaxNumber(10)(value)
      message: 'not over 10',
    },
  ]}
>

If we allow empty value 😃 :

<Field
  name="myField"
  validations={[
    {
      rule: isNumber()
      message: 'not a number',
    },
    {
      rule: isMinNumber(1)
      message: 'not under 1',
    },
    {
      rule: isMaxNumber(10)
      message: 'not over 10',
    },
  ]}
>

[ivan-dalmet]

Available in version 1.0.0-rc.4 🙂

[yoannfleurydev]

I think we should introduce a new validation for this kind of wanted behavior: isOptionalNumber or something like that. So isNumber stays the same.