Comments (3)
Wow, you are on fire :)
Having it as a method on the mixin is a much better idea than mine too, very good.
Thank you. I shall give this a whirl tomorrow.
from django-wm.
Thanks for the suggestion - it was silly to have it require a unique slug in the first place, this makes it much more flexible.
I had a look at your repo and used a simplified version of your models and urlpatterns to test against so hopefully it's good to go!
from django-wm.
Just wanted to let you know that I've got the basics working and have it live on my site now, quietly! Thank you so much for your assistance.
I just need to work out how best to make it visible to people on my site now which is my own problem :)
One odd thing I noticed with my /webmentions/
endpoint, and I'm not sure if it's intentional...
- Using a valid blog post target URL returns a 200 and no error message
- Using an invalid URL returns a 404 and the "Target not found" message
- Using a URL that's a valid blog post URL format, but doesn't match a post object returns a 200 and no error message
- Using the valid target URL but without the trailing slash returns a 404 and the "Target not found" message
- Using a URL that's any other valid page, but not a blog post, returns a 200 and no error message
1 & 2 seem correct.
3. Seems wrong - not sure if it's a bug or if I need to do something further in my resolve_from_url_kwargs()
method?
4. Is maybe technically correct, but I've seen bits of the django-wm code that tries both with and without trailing slashes, so I was surprised.
5. I could see a case for being correct - the page does exist! I assume it's not within the scope of the webmention endpoint to say whether it accepts mentions or not?
from django-wm.
Related Issues (20)
- Add an option to work without Celery? HOT 8
- Running makemigrations creates migration files in installed package directory HOT 2
- Feature request: Add webmention type
- Expand the allowed versions of the required requests package? HOT 2
- How to only send webmentions from "live" objects?
- Add template for successful submission of webmention
- Don't make links to same-page #anchors into targets
- HCards only being found if they're the first item in the soup
- Should HCards be found within h-entry's?
- Quote text is never set HOT 2
- Multiple outgoing mentions created when connections repeatedly fail HOT 5
- Still trying to send webmentions to #anchor links? HOT 3
- Webmentions being accepted by pages that aren't Mentionable HOT 4
- Mentions for models without a `slug` field HOT 2
- Webmention endpoint resolution failing when there are multiple `link`s in header HOT 3
- Single incoming webmention repeatedly being processed. HOT 6
- Problem integrating django-wm with Wagtail HOT 21
- RuntimeError for incoming webmentions HOT 5
- How to debug the Outgoing Mentions functionality HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-wm.