Comments (8)
I submitted PR #3796 to address this issue, adding safer file removal operations for users who have a trash
executable on their systems. This provides the option for a safer user experience without adding yet another Python dependency.
from beets.
Problem
Run beet import on an album that's already in the library. Say Remove old. The old files are instantly deleted, not sent to the recycle bin. Recycle-binning deleted files is typical behavior; I can't think of any Windows program that doesn't do this for user-facing files.
Alternatively, a user-designated "Trash" folder in the library could be specified, but that's complicated.
(See: duplicates plugin)
Could a user-specified trash folder actually be easier than using a third-party dependency to manage trash on individual OSs? A config option could specify "delete instantly" or "send to custom trash folder: /library/trash" or something.
from beets.
Send2Trash looks like it might be good for this, although I'm not sure if it's worth adding another dependency for. Might be worth implementing as a plugin though.
from beets.
Where do the main developers stand on this now? Would either of these be accepted if a pull request was made?
- Using send2trash to send trashed files to OS-level trash directory
- Moving trashed files to a /trash/ folder within the beets library (or perhaps any user-specified path) for the user to manually examine and delete later
from beets.
I'm still in favor but not thrilled about a new core dependency to support it. I like the idea of a plugin, though!
from beets.
As a mainly linux guy, I didn't and still don't really feel the need for recycle-binning.
I am not that excited about a new dependency to the beets core either, and going around this by moving trashed files to a beets-specific path defeats the purpose of a recycle-bin to me (I understand it as a place you take a look at where you are in need of disk space, so that files are really deleted only when they need to be?).
I don't see anything against using send2trash in a plugin though!!
from beets.
I'm having this issue as well, on macOS. It is constantly deleting my files even though I never ask it to. Fortunately I have iTunes Match / Apple Music so everything is backed up in the cloud. But this is a nasty bug.
from beets.
This issue isn't about beets randomly deleting your files - it definitely shouldn't be doing that. Could you please open a new issue @austinarchibald?
from beets.
Related Issues (20)
- KeyError: 'title' during import [fromfilename plugin] HOT 1
- Simplifying item/album handling in the plugin API
- Undocumented config feature not in the docs: overwrite_null HOT 2
- Beets should remove deleted albums from history while updating
- Beet edit doesn't show custom tags
- Remove 'slow sort' by performing all sorting in SQL only
- Remove the need for additional queries in template variables resolution
- Add a benchmark command to poe
- beet move crashes my laptop and breaks my external memory HOT 2
- Error when loading `convert` plugin HOT 5
- Consider making the `rich-tables` dependency optional
- Itunes ignores albumartist_sort
- Regression in 2.0.0: import UI is useless in ligth theme HOT 7
- Listenimport plugin is currently broken
- Match smartplaylist options with playlist plugin
- deezer plugin doesn't handle pagination in tracklist
- In 2.0.0 (from git snapshot), running 'beet splupdate' (for smartplaylist) fails with TypeError whenever 'playlist:x' is in any query
- File not found exception aborts import - occurs during "remove old"
- Migrate tests from `unittest` to `pytest` HOT 1
- I have two issues: 1st could not set permissions on... 2nd FileNotFoundError: [Errno 2] No such file or directory:... then crash!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beets.