Comments (3)
Amazing! Both libraries now produce the exact same result, down to the millisecond!
I used the Java zmanim project directly this time so I could get an exact comparison. This is what I got from Java:
ComplexZmanimCalendar cal = new ComplexZmanimCalendar(
new GeoLocation(
"Hasmonaim",
31.93263,
35.02327,
255.18,
TimeZone.getTimeZone("Asia/Jerusalem"))
);
cal.getCalendar().set(2020, Calendar.APRIL, 10);
System.out.println(cal.getCandleLighting().getTime()); // 1586533670912 (Fri Apr 10 2020 18:47:50)
And the JS using the updated kosher-zmanim:
const { ComplexZmanimCalendar, GeoLocation } = require("kosher-zmanim");
const cal = new ComplexZmanimCalendar(
new GeoLocation("Hashmonaim", 31.93263, 35.02327, 255.18, "Asia/Jerusalem")
);
cal.setDate("2020-04-10");
console.log(cal.getCandleLighting().toJSDate().getTime()); // 1586533670912 (Fri Apr 10 2020 18:47:50)
Awesome stuff 👍
from kosherzmanim.
P.S. I'd love to get involved in solving this issue. I just first wanted to know if you were aware of it.
from kosherzmanim.
There were several bugs in the last version. Please try again with v0.6.0 and let me know if there is still an issue.
As far as we know, MyZmanim uses their own proprietary calculations, and does not use KosherJava or any of its ports. The author of KosherJava frequently gets complaints that his calculations are different than MyZmanim.
from kosherzmanim.
Related Issues (12)
- Very Nice! HOT 1
- Is this project still maintained? HOT 1
- none json example and jerusalem timezone issue HOT 1
- problem in demo code HOT 2
- getZmanimJson does not return plagHamincha
- Wrong Times For Asia/Jerusalem Timezone
- Add tefilla rules HOT 1
- Can we please have an actual example of using this project not through JSON?! HOT 3
- Add ESM bundle
- why Timezone ID & Location Name are mandatory ? HOT 2
- Bug in getMoladAsDate - JewishCalendar - Jerusalem Time Zone HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kosherzmanim.