JS doesn't produce the same results as Java

[shalomscott]

JS doesn't produce the same results as Java

[shalomscott]

Amazing! Both libraries now produce the exact same result, down to the millisecond!

I used the Java zmanim project directly this time so I could get an exact comparison. This is what I got from Java:

ComplexZmanimCalendar cal = new ComplexZmanimCalendar(
        new GeoLocation(
                "Hasmonaim",
                31.93263,
                35.02327,
                255.18,
                TimeZone.getTimeZone("Asia/Jerusalem"))
);

cal.getCalendar().set(2020, Calendar.APRIL, 10);

System.out.println(cal.getCandleLighting().getTime()); // 1586533670912 (Fri Apr 10 2020 18:47:50)

And the JS using the updated kosher-zmanim:

const { ComplexZmanimCalendar, GeoLocation } = require("kosher-zmanim");

const cal = new ComplexZmanimCalendar(
  new GeoLocation("Hashmonaim", 31.93263, 35.02327, 255.18, "Asia/Jerusalem")
);

cal.setDate("2020-04-10");

console.log(cal.getCandleLighting().toJSDate().getTime()); // 1586533670912 (Fri Apr 10 2020 18:47:50)

Awesome stuff 👍

[shalomscott]

P.S. I'd love to get involved in solving this issue. I just first wanted to know if you were aware of it.

[BehindTheMath]

There were several bugs in the last version. Please try again with v0.6.0 and let me know if there is still an issue.

As far as we know, MyZmanim uses their own proprietary calculations, and does not use KosherJava or any of its ports. The author of KosherJava frequently gets complaints that his calculations are different than MyZmanim.