Giter Site home page Giter Site logo

Comments (2)

niranjan92 avatar niranjan92 commented on July 2, 2024

Any updates on this issue?

Regards,

from fast-cpp-csv-parser.

ben-strasser avatar ben-strasser commented on July 2, 2024

Hi,

this problem already appeared previously and I decided to not fix it at that
time. The reasons were:

  • CSV files that contain newlines within a line that do not separate lines are
    defective in my opinion. The first step should consist of fixing the file.
  • Splitting up the lines is done in LineReader. Unescaping quotes is done in
    CSVReader but only if the right policies are set. LineReader knows nothing
    about quotes and thus can not know whether a newlines is within quotes or not.
    The whole quoting logic is contained within a CSVReader policy. I therefore
    see no straightforward way of making this "just work" without major interface
    breaking changes to the design.
  • The most frequent use case consists of parsing CSV-files that only contain
    numbers and perhaps non-escaped strings. I do not want to add logic to
    LineReader that makes this use case slower.
  • Windows vs Linux newlines, i.e., "\r\n" vs "\n", make this whole problem
    significantly worse. Note that, these two can appear simultaneously within
    one file. Sidenote: This whole Linux vs Windows is also the reason why the
    newline characters are hardcoded within LineReader and not part of a
    template parameter, as they should in an ideal world.

If you know of a good way to support such ill-formed CSV files, then I can add
the change. If not, then this problem will stay.

Best Regards,
Ben Strasser

On Sat, 06 Jun 2015 12:06:31 -0700
Niranjan Godbole [email protected] wrote:

Any updates on this issue?

Regards,


Reply to this email directly or view it on GitHub:
#2 (comment)

from fast-cpp-csv-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.