Giter Site home page Giter Site logo

Comments (4)

gcflymoto avatar gcflymoto commented on August 22, 2024

how do you expect that to be legal? shouldn't quotes be escaped?

from fast-cpp-csv-parser.

niranjan92 avatar niranjan92 commented on August 22, 2024

Its not an outright error, But the library doesn't support that functionality.

I using data released by stackoverflow.com for a tag prediction competition on Kaggle. I think Excel to csv conversion results in such data. http://stackoverflow.com/questions/25064422/excel-to-csv-to-txt-cells-with-double-quotes

As per wiki: http://en.wikipedia.org/wiki/Comma-separated_values

Embedded double quote characters may then be represented by a pair of consecutive double quotes,[9] or by prefixing an escape character such as a backslash (for example in Sybase Central).

from fast-cpp-csv-parser.

ben-strasser avatar ben-strasser commented on August 22, 2024

Hi,

thanks for the bug report. I can confirm the problem. The erroneous code
is in line 601.

char_out = col_begin;
for(char_in = col_begin; in!=col_end; ++in){
if(*in == quote && *(in+1) == quote){
continue;
}
*out = *in;
++out;
}

When unescaping the string the code drops every " that is followed by
another ". This is correct in the case of "bla""foo""bar" but fails in
the case of "foo""""bar".

Does the following code work for you? (I currently do not have the time
to test.)

char_out = col_begin;
for(char_in = col_begin; in!=col_end; ++in){
if(*in == quote && *(in+1) == quote){
++in;
}
*out = *in;
++out;
}

Best Regards,
Ben Strasser

On 06/03/2015 08:30 PM, Niranjan Godbole wrote:

Fails to parse following input:

| "Id","Title","Body","Tags"^M
"1","How to check if an uploaded file is an image without mime type?","

<img src="http://i.stack.imgur.com/bA7Tz.jpg" alt="""">


","php image-processing file-upload upload mime-types"^M
|

The output for Body column should be

|


|

But the ouput is:

|

<img src="http://i.stack.imgur.com/bA7Tz.jpg" alt=">


|


Reply to this email directly or view it on GitHub
#3.

from fast-cpp-csv-parser.

niranjan92 avatar niranjan92 commented on August 22, 2024

yes, the given fix works! Thanks. :)

from fast-cpp-csv-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.