Ion Auth not storing IP address in users table

[benedmunds]

Ion Auth not storing IP address in users table

[benedmunds]

Are you using this locally or on the web? You won't usually get an IP locally.

[rhopek]

On the web. The ci_session table gets updated with the IP, but nothing in the users table.

[benedmunds]

Hey, sorry I forgot and had to look it up in the code.

It only stores the IP on user registration. Personally, I've never needed it but it's a leftover from Redux Auth...

[rhopek]

Thx. If it's not something on your roadmap, I guess we'll just need to update code to store it on logins. It makes sense to store both the last_login and the ip it was from.

[benedmunds]

Yea, you should just add it to the meta data and update it on login. Then you'll have both the registration ip and the login ip.

[rhopek]

The column is already there in the users table. Why wouldn't we just want to modify the login code of Ion Auth to include adding the IP to that column on each login (just like the last_login timestamp) rather than creating yet another column in another table? Seems a tad senseless. Please enlighten us if you have other rationale; we're all ears.

[benedmunds]

I don't have a use case but the reason for me is backwards compatibility. Since that functionality has worked that way since Redux there's a very good chance people will use it for something and expect it to work the way it does now. If we change it now then we'd likely break somebody's functionality on upgrade.

Feel free to change it if that's what you want for your project but I would recommend using meta data so you can easily upgrade in the future.