Does the DllRewriter break the PDB?

[benjamin-hodgson]

Does the DllRewriter break the PDB?

[benjamin-hodgson]

@andrewsav-datacom The two methods in question aren't even expressible in unsafe C#, and in fact there's some almost identical code shipped as an official .NET package. So I'd argue it's more an expressiveness issue than a safety one: you can't write it in C# because you can't, not because it's dangerous. It is dangerous, but that's not why you can't write it. There are plenty of non-dangerous programs you can't write in C#, and there are plenty of dangerous programs you can write even in safe C#.

In this specific case the two methods convert a ref Span<T> to a void* and back. I need to do this so I can store a reference to a Span (living on the stack) on the heap. This is safe as long as the heap object containing the reference doesn't outlive the stack frame containing the span. I know this is true because I wrote my code carefully: the Parse method is synchronous, and the TokenStream is not stored anywhere, so it'll become garbage before the Span's stack frame is popped.

Sometimes you need to be allowed to point a gun at your foot in order to shoot a bug between your toes.

[benjamin-hodgson]

08936ec 998700b

[mustik22]

Confirmed, now able to debug Pidgin project.

Thanks

[andrewsav-bt]

@benjamin-hodgson can you explain why is it safe to use the rewriting?

[andrewsav-bt]

@benjamin-hodgson Is there a better way to contact you to clarify this?

[benjamin-hodgson]

@andrewsav-datacom This issue was just a bug in the build scripts. What would you like to know exactly?

[andrewsav-bt]

@benjamin-hodgson apologies, my question was not related to the issue, now when you mentioned it, it was not very appropriate place to ask, I probably should have opened a new one.

The reason the compiler does not let you write this code and you have to do the rewriting, is because the compiler consider this unsafe. Of course the compiler does not know what you know, and is concerned with not letting you shoot yourself in the foot.

My question is: what about your use case that makes this rewriting safe?

Thank you in advance.