Comments (9)
I'll take a look at this. You're right though, if it's a bytes message, it should use buffers instead of strings.
from stomp-js.
Can you please try out branch issue-15 (https://github.com/benjaminws/stomp-js/tree/issue-15). All it does is convert the body of the message back to a buffer if it's detected that the message is a binary message (by the presence of content-length header).
from stomp-js.
That doesn't help. The bytes are already lost in translation before that.
from stomp-js.
Doh, you're right. I'll try another approach. This whole codebase needs a major refactoring :(
from stomp-js.
New approach will leave the buffer intact, only slicing out the command/header bits as needed. Can you pull it down and test it for yourself?
from stomp-js.
Looked at this again. Problem is more annoying that I initially thought. Working on a fix, though. Should have something cooked up tomorrow.
from stomp-js.
The body is still not a buffer (it's a Frame) which still mangles up the bytes.
from stomp-js.
Right. Hence the last note. Will hopefully have a fix today. The problem is the way I'm handling the incoming buffer, trying to treat it as a string initially instead of a buffer. Needs some extra work to parse out what I need from the buffer (no niceties like split, indexOf, etc on a buffer).
from stomp-js.
Greatly appreciate your work.
from stomp-js.
Related Issues (20)
- Existing messages parser issue HOT 7
- NPM release HOT 2
- Support for Stomp 1.1 ? HOT 1
- Please change EventEmitter inheritance way HOT 4
- Stomp.on('error') Not Called for TLS Errors HOT 2
- Does it support reconnect automatically HOT 4
- Partial messages in ondata event being processed as completed HOT 3
- activemq.prefetchSize ignored?
- When disconnecting, the client should forward a DISCONNECT message
- Is this project abandoned? HOT 4
- problem with send on ie8
- Missing npm dependencies HOT 6
- can`t read the property trim of 'undefind HOT 2
- Error connecting to TIBCO queue
- ignore
- pipelined frames do not work
- Cannot find module "tls"
- net.createConnection is not a function
- Producer Send return callback
- stomp consumer throws exception when use queue name like PRICE.STOCK.>
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stomp-js.