Giter Site home page Giter Site logo

Feature: Promises about node-simple-aws HOT 2 OPEN

konsumer avatar konsumer commented on May 26, 2024
Feature: Promises

from node-simple-aws.

Comments (2)

konsumer avatar konsumer commented on May 26, 2024

The API can actually stay the same (with added promise support) with a bit of trickery testing the last param to see if it's a function.

For example:

await ddb.putItem('TEST', { id: 'TEST' })

in ddb.putItem, check if typeof cb === 'function', and if it is use that as callback, otherwise use a generated promise-callback for underlying client-call.

const promise = new Promise()
if (typeof cb !== 'function'){
  cb = (err, ret) => err ? promise.reject(err) : promise.resolve(ret)
}
// ... later
return promise

from node-simple-aws.

konsumer avatar konsumer commented on May 26, 2024

I ended up just wrapping every this.method with promisify as it maintains backward-compatibility, and will keep the API mostly the same, with minimal effort.

from node-simple-aws.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.