Odd behavior when generating a manifest file

[bensampaio]

Odd behavior when generating a manifest file

[bensampaio]

@thasmo I looked into it and I think I might have found the source of the problem. Could you give it a try with the changes in: #60 and let me know if that works for you?

[bensampaio]

Cool! I'll see if I get it merged and release it this week :)

[bensampaio]

The fix is now merged and released so I'll close this issue. Thanks for reporting!

[thasmo]

By the way, the sprite files are generated correctly.

[thasmo]

It seems that using a dash (-) in the name option is the problem.

The configs ...

{
    name: 'sprites/one.[hash:8].svg',
    iconName: '[name]',
}

{
    name: 'sprites/two.[hash:8].svg',
    iconName: '[name]',
}

{
    name: 'sprites/three.[hash:8].svg',
    iconName: '[name]',
}

are successfully used on the generated manifest.json ...

  "one.svg": "/static/sprites/one.baa8a64a.svg",
  "two.svg": "/static/sprites/two.7ba348af.svg",
  "three.svg": "/static/sprites/three.16fdbfb9.svg",

... but using sprites/brand-one.[hash:8].svg, sprites/brand-two.[hash:8].svg, etc. will be reduced to a single entry in the manifest.json file with the key brand.svg.

[bensampaio]

@thasmo I might be wrong but I don't see why this would be a problem with this package. Could you try to use https://www.npmjs.com/package/webpack-manifest-plugin and see if it results in the same behavior? I used it before and never had problems with it. I guess webpack-assets-manifest is using a regex somewhere that does not take dashes into account 🤔

[thasmo]

@bensampaio I've tried it with assets-webpack-plugin and it behaves similarly; it somehow ditches everything after a dash, including the dash. When not using a dash in the name it works fine.

[thasmo]

@bensampaio That seems to fix it, awesome!