Support for Redis ACL Type Auth

[tfendt-belong-gg]

Support for Redis ACL Type Auth

[peczenyj]

@tfendt-belong-gg yes you should fork, write your contribution and apply it via Pull Request

[peczenyj]

Don’t worry

after submit the PR there are some GitHub actions. One is the DCO that will check the signatures and will provide you a command line to fix is combining git rebase and force oush

[mihaitodor]

Hey @tfendt-belong-gg 👋 looks like a reasonable addition to make. PRs are welcome! You'll also want to modify the clientFields() function to add that example and then run make docs and commit the changed .md files.

[tfendt-belong-gg]

@mihaitodor Do I have to fork the repo first and create a PR from that? It doesn't appear I can create a branch on this project.

[peczenyj]

Optionally you can create a branch in your repo/fork, that is your organization of work.

for some trivial changes we can use the web interface of GitHub itself, that can perform some operations automatically. However some operations must be done such as run make docs

btw, after your first git push, the option to create a pull request will be visible in the web interface of your repo and I think each push will be followed witha link to create the pull request. So it is (almost) piece of cake.

but remember that you MUST sign your commits (add -s to the git commit command line).

[tfendt-belong-gg]

PR created! #2240

I didn't sign the commit though. Should I go back and add an empty commit with the -s flag?

[tfendt-belong-gg]

How long until reviews happen and this can be merged in? I just need to know if I should come up with a temp solution for our project while we wait.

[Jeffail]

@tfendt-belong-gg it's a small and sensible change so I can merge it now, I'm expecting to do a release probably next week.

[tfendt-belong-gg]

@tfendt-belong-gg it's a small and sensible change so I can merge it now, I'm expecting to do a release probably next week.

Wow! Thank you. I'll let my team know.