Comments (4)
Yes, we should fix that. I suspect this is a case of me adding config file support "after the fact".
from s3deploy.
Thinking about this.
bucket: example.com
key: xcsds
region: us-east-2
secret: xdsfdsf
source: public
I don't think key/secret should be in this file, as it this file should be committed to GitHub, secrets should .... stay secret.
from s3deploy.
I don't think key/secret should be in this file, as it this file should be committed to GitHub, secrets should .... stay secret.
Sure for GitHub. But those that use private BitBucket repositories, like me, can safely commit the key and secret in the config file. Perhaps we can add a warning about this in the README file?
from s3deploy.
Perhaps we can add a warning about this in the README file?
Yes, OK, that would be good. I guess there are plenty of ways a user can shoot him/herself in the foot.
from s3deploy.
Related Issues (20)
- Invalidating multiple CDN HOT 4
- Invalid memory address or nil pointer dereference HOT 1
- Add support for SSE aws:kms and kms-key-id HOT 2
- Fix the brew release for > 2.9.0
- s3deploy_2.9.0_windows-amd64.zip contains `hugo.exe` HOT 3
- s3deploy credentials sourcing HOT 3
- No binaries for the 2.10 release HOT 2
- Force setting does not force? HOT 2
- Inconsistent verbose output
- Encode unsafe characters in CloudFront cache invalidation paths
- Missing newline in output when enqueuing file HOT 1
- Prettify output? (Feature request, rather than an issue) HOT 2
- Decrease max-age Cache-control value used in examples to follow RFC
- Feature request: Allow opt in (whitelist) of hidden folders HOT 1
- Using Circleci Auto-deploy is suddenly stopped HOT 1
- flag provided but not defined: -distribution-id HOT 4
- Security-related Headers in s3deploy.yml? HOT 5
- Allow setting other canned ACLs for uploaded files
- CDN invalidate does not handle root context stored in a bucket sub path
- fatal: unable to access 'https://gopkg.in/yaml.v2/': server certificate verification failed. CAfile: none CRLfile: none HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s3deploy.