Ridley::Chef::Config fails to parse `knife[:option] = value` configurations

[berkshelf]

Ridley::Chef::Config fails to parse `knife[:option] = value` configurations

[reset]

@tmatilai thanks for pointing this one out!

[ivey]

berkshelf/buff-config#4

[scalp42]

Running into the same issue here.

[ivey]

Let's do a special-case for the knife hash in Ridley, and still fix the main issue in buff-config.

[ivey]

So...I can't repro this, actually. Ridley::Chef::Config has a knife hash already, and I am able to load a knife.rb using it.

https://github.com/RiotGames/ridley/blob/master/lib/ridley/chef/config.rb#L63

Can I see a full knife.rb (elided certs/URLs is OK) for someone with this issue?

[tmatilai]

@ivey Here you have a simple repro: https://github.com/tmatilai/ridley-issue-202-repro

The knife hash in Ridley::Chef::Config does not affect anything as the error comes already from Buff::Config::Ruby::Evaluator, that doesn't know anything about the Ridley::Chef::Config / Buff::Config::Ruby attributes.

[ivey]

Thanks. Turns out Ridley::Chef::Config.new doesn't expand '~' so my test was bad. I can repro in ridley master without berks, so it'll be easier to find. Will update later.

[sethvargo]

@ivey we should File.expand_path that shiz 😄

[ivey]

I have a working fix in berkshelf/buff-config#5 but I need to write tests for it and I am out of time this AM. Someone want to write a few tests for me?

Otherwise will try to clean up and have ready to merge tonight.

[ivey]

@sethvargo #211

[sethvargo]

@ivey I'm totally swamped; you'll probably get to it before me

[ivey]

That one is a great place for someone to jump in and help. Also, tests on this one. :-)