Giter Site home page Giter Site logo

Comments (9)

dbertella avatar dbertella commented on August 25, 2024 1

from react-overdrive.

berzniz avatar berzniz commented on August 25, 2024

Thanks for reporting. What is your setup? no build pipeline, webpack, rollup, browserify? If you can share more information that would be great

from react-overdrive.

anri-asaturov avatar anri-asaturov commented on August 25, 2024
  • Electron latest
  • react-router 3.x.x
  • react latest
  • mobx latest
  • react-toolbox - this might be important because my entire app is wrapped in ThemeProvider that provides context for react-toolbox control.

When I inspect application state at the exception point - what happens is react is trying to instantiate(probably as a reaction to Overdrive clone) element that has type === undefined.

Nothing else important, no packagers, no browserify.

Latest update of Overdrive with context support didn't fix it btw.

from react-overdrive.

berzniz avatar berzniz commented on August 25, 2024

Thanks for all the information. Will you have time to construct a basic example that shows the bug? I can trace the bug from there

from react-overdrive.

anri-asaturov avatar anri-asaturov commented on August 25, 2024

In a few weeks our app sources will get published and I'll ping you.

from react-overdrive.

dbertella avatar dbertella commented on August 25, 2024

I might have a similar problem. I just introduce the library but I'm not sure that I did everything I should. You can find some working example at this repository: https://github.com/dbertella/food-and-quote/tree/try-react-overdrive (I create a branch for it) I'm using latest version of create react app for the record.

from react-overdrive.

berzniz avatar berzniz commented on August 25, 2024

I see the two usages of <Overdrive>:

  1. Passes two children instead of one
<Overdrive id={post.slug}>
  {
    post.featured_image && <img src={`${post.featured_image}?w=640&h=360&crop=1`} alt={post.title} />
  }
  <Title dangerouslySetInnerHTML={createMarkup(post.title)} />
</Overdrive>

which is more than one children. Try wrapping them with a <div>.

  1. Uses a react component
<Overdrive id={p.slug}>
  <Card>...</Card>
</Overdrive>

where <Card> needs to allow styling, meaning that if it gets a prop of style it uses it on the first element. example:

const Card = (props) => {
  const {style} = props;
  return <div style={style}>...</div>
}

alternatively, you can also wrap the <Card> in a <div>

from react-overdrive.

dbertella avatar dbertella commented on August 25, 2024

from react-overdrive.

berzniz avatar berzniz commented on August 25, 2024

Going to close for "no activity". @dbertella - any news on that?

from react-overdrive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.