Compiler error on SITL target

[betaflight]

Compiler error on SITL target

[mikeller]

@kmitchel: Building SITL in the docker VM is not supported - since the SITL target needs a linux environment to run in anyway, the best approach is to build it on the machine it will be run on.

[kmitchel]

Would it be acceptable to move SITL into UNSUPPORTED_TARGETS, so it's not caught up in ALL?

[mikeller]

Not really, as UNSUPPORTED_TARGETS isn't specific to the docker build.

The docker build environment was created to give users not running linux a way (amongst others) to build individual targets, and specifically to allow them to do so without having to install a lot of different tools.

From the sound of it, what you are trying to do is different from this, so there might be a better way for you to get there. Can you please describe what you are trying to do?

[kmitchel]

Out of curiosity, I was trying to compare compile times between the docker container, and a XUbuntu-Core 18.04 VM. I have no real need of the SITL target, just noticed that it killed off the docker build.

I played with adding a docker-all target
in dockerfile
41:make ARM_SDK_DIR=${ARM_SDK_DIR} all_docker ${EXTRA_OPTIONS}; \

in Makefile
331:all_docker: $(DOCKER_TARGETS)

in targets.mk
DOCKER_TARGETS := $(filter-out $(SITL_TARGETS), $(VALID_TARGETS))

It doesn't work. if I replace $(SITL_TARGETS) with SITL it works...like $(SITL_TARGETS) isn't populated.

[mikeller]

@kmitchel:

Ah, interesting. What were your findings?

The one thing that I think might be of interest for users would be to compare these build times to the build times of builds done in WSL (https://github.com/betaflight/betaflight/wiki/Building-Betaflight-on-Windows,-the-Linux-subsystem-way).

It would probably be relatively easy to add gcc and any other tools / libraries required to build SITL to the list of packages that is installed through the Dockerfile - if you do so please open a pull request to add this to the official Dockerfile.

[kmitchel]

dockerfile 17:RUN DEBIAN_FRONTEND=noninteractive apt-get -y install gcc

Kind of surprised it was that simple. SITL compiles with a warninlib/main/dyad/dyad.c: In function 'dyad_update':
lib/main/dyad/dyad.c:738:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (select_has(&dyad_selectSet, SELECT_READ, stream->sockfd)) {
^
lib/main/dyad/dyad.c:746:7: note: here
case DYAD_STATE_CLOSING:
^~~~g

I'll continue to test tomorrow, TY.

[mikeller]

I assumed it would be - SITL is a native linux build. The warning is probably just a switch statement that needs an explicit FALLTHROUGH - these warnings got added to gcc after the SITL target was introduced.