Giter Site home page Giter Site logo

Comments (11)

rochford77 avatar rochford77 commented on June 26, 2024 3

@sugaarK I understand that was the intent of the official/community/experimental flags, but people are still posting because they are confused. This is probably due to the preset being basically necessary while in experimental status before OSR4 was the default, combined with the popularity of the 4.3 pre-release stage.

@DusKing1 I'm looking at the preset in the configurator right now and all I see for a description is:

These settings are for BMI270 gyroscope only. With only these settings, the BMI270 will give a nice output and control performance. Please check the available options in this preset.

The text you are talking about is listed in the warning, people aren't getting that far before going on Facebook/discord and asking how to proceed. Maybe moving that verbiage to the description and making it "Duskings Advanced BMI270 filters", along with the already included "experimental" flag will make things a bit more clear.

Also, I'm not trying to "complain" I'm trying to help lower the number of questions in the community in regard to this popular preset.

from firmware-presets.

limonspb avatar limonspb commented on June 26, 2024 2

I'm for option N1, renaming it to something like... Idk to what but something that tells user. And of course adding more to description is good.

Option N2 - mark as 4.2, this can't be done because in 4.2 we didn't have a BMI support.

Option 3 - I think some people still might find it interesting to try non-osr mode. I haven't done it myself yet but planning :)

Blocking was def a weird thing by @DusKing1, maybe accidentally

from firmware-presets.

sugaarK avatar sugaarK commented on June 26, 2024 1

ive removed them

from firmware-presets.

rochford77 avatar rochford77 commented on June 26, 2024

The PRs in question are

#141

#182

from firmware-presets.

SupaflyFPV avatar SupaflyFPV commented on June 26, 2024

thanks for the comment Ryan, I agree with you. I think if we feature this preset we should update it.

from firmware-presets.

DusKing1 avatar DusKing1 commented on June 26, 2024

Maybe i blocked wrong users as i have received some spam on my other repos.

But the name for that is already "DusKing's BMI270 filter settings", IDK what you are complaining.

from firmware-presets.

SupaflyFPV avatar SupaflyFPV commented on June 26, 2024

Maybe i blocked wrong users as i have received some spam on my other repos.

But the name for that is already "DusKing's BMI270 filter settings", IDK what you are complaining.

I think it is confusing as users do not understand whether they need to select this preset or not...

Would you consider adjusting the preset to use the Betaflight filter defaults, with the Gyro Low Pass Filter slider instead of the PT2/PT3? It would make more sense...the gyro low pass slider can be changed to eg 0.5 and then the user could adjust if necessary...

from firmware-presets.

DusKing1 avatar DusKing1 commented on June 26, 2024

Maybe i blocked wrong users as i have received some spam on my other repos.
But the name for that is already "DusKing's BMI270 filter settings", IDK what you are complaining.

I think it is confusing as users do not understand whether they need to select this preset or not...

Would you consider adjusting the preset to use the Betaflight filter defaults, with the Gyro Low Pass Filter slider instead of the PT2/PT3? It would make more sense...the gyro low pass slider can be changed to eg 0.5 and then the user could adjust if necessary...

It would be great if just adding an "Advanced"/"Extreme" would change the user's misconception (if it exists), however the fact is that the preset already has the "DusKing's" prefix, but according to the above statement, this does not change the so-called "user misconception".

No I wouldn't do it, a single static PT2/PT3 is enough. The default dynamic low pass will only mess up the final signal performance of the BMI270 in performance mode (according to the datasheet).

from firmware-presets.

sugaarK avatar sugaarK commented on June 26, 2024

The users should be able and I tell the difference between experimental and offical presets with the coloured flags that the presets have but even somthing as obvious as that goes over so many peoples heads!!
@DusKing1 maybe make it clear in the description that this is not suitable for the osr4 mode which is now stock in bf 4.3 where the bmi270 gyros can be run with more traditional filtering…

from firmware-presets.

DusKing1 avatar DusKing1 commented on June 26, 2024

@sugaarK please just check the preset in the latest master rather the links @rochford77 provided, they have the description as This preset also changes DLPF cutoff of BMI270 to 751Hz to provide the lowest latency.

from firmware-presets.

haslinghuis avatar haslinghuis commented on June 26, 2024

Fixed in #329

from firmware-presets.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.