Giter Site home page Giter Site logo

Comments (5)

FluorescentHallucinogen avatar FluorescentHallucinogen commented on July 26, 2024

Just found that if notificationclick event listener has event.notification.close() inside, then on some Android devices the notification successfully closes after clicking on "Send" icon, but on some not, the typed text is just added at the top.

This is exactly the same as the behavior of native Android apps on these devices. I've tested in Telegram. On some Android devices the notification successfully closes after clicking on "Send" icon, but on some not, the typed text is just added at the top.

But if notificationclick event listener has no event.notification.close() inside, then after clicking on "Send" icon it becomes a spinner that spins endlessly, the notification won't close on all Android devices.

@beverloo I think this is a bug, the spinner shouldn't spin endlessly, the notification should close (after some timeout). Could you please confirm?

from peter.sh.

FluorescentHallucinogen avatar FluorescentHallucinogen commented on July 26, 2024

Just found a very similar problem on StackOverflow: https://stackoverflow.com/q/51815139.

from peter.sh.

beverloo avatar beverloo commented on July 26, 2024

That certainly sounds like an issue on certain builds of Android—this is one of Chrome's manual test cases iirc. The intended behaviour in the spec (& in Chrome's implementation) is that calling notification.close() always closes the notification.

from peter.sh.

FluorescentHallucinogen avatar FluorescentHallucinogen commented on July 26, 2024

@beverloo Could you please try to reproduce it yourself on your Android devices and your https://tests.peter.sh/notification-generator/ test page? But just remember, we are talking only about the notification inline reply case.

As I said, there are 2 problems:

  1. If there is event.notification.close(), the"Send" icon becomes a spinner that spins endlessly, and the notification won't close.
  2. If there is no event.notification.close(), the typed text is just added at the top, and the notification won't close.

from peter.sh.

FluorescentHallucinogen avatar FluorescentHallucinogen commented on July 26, 2024

@beverloo I've opened https://crbug.com/1290426.

from peter.sh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.